Fix file permissions of generated color files [#119196]

The color module is not setting the file permissions on created files. This is a problem on sites that have a tight umask (i.e. 077). Similiar patches found their way into core in D5 (for example, the new install system), but as color is a new core module, the fixes did not make it here yet.

This patch should fix many of the Garland related problems, such as 110916 and maybe 97661, although I suspect there are more.

Comment	File	Size	Author
#7	119196.patch	1.88 KB	douggreen
#7
#2	color_2.patch	1.75 KB	douggreen
#2
	color_1.patch	1.4 KB	douggreen

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Owen Barton CreditAttribution: Owen Barton commented 15 February 2007 at 07:59

subscribing

Comment #2

douggreen CreditAttribution: douggreen commented 16 April 2007 at 14:47

Version:

5.x-dev

» 6.x-dev

File	Size
color_2.patch	1.75 KB

I had hoped that this would get into the 5.x bug fix releases, but seeing no movement here, the same problem exists in 6.x. While the original patch works for 5.x, the attached patch is re-rolled for 6.x (with slightly different line numbers).

Comment #3

douggreen CreditAttribution: douggreen commented 1 July 2007 at 02:33

Title:

File Permissions - solution to Garland problems

» Fix file permissions of generated color files

Comment #4

douggreen CreditAttribution: douggreen commented 1 July 2007 at 02:36

I just confirmed, this patch still applies.

Comment #5

douggreen CreditAttribution: douggreen commented 1 July 2007 at 13:08

We've been running this patch on all of our D5 sites ever since D5 was released, with no ill-effects. As real world scenerio's go, this patch only comes into effect when/if you use Garland's color picker. So, we've really only used it for a couple sites.

Comment #6

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard commented 1 July 2007 at 14:07

There should probably be a brief comment regarding the permission setting. Here's what file.inc does in a similar context.

    // Give everyone read access so that FTP'd users or
    // non-webserver users can see/read these files,
    // and give group write permissions so group memebers
    // can alter files uploaded by the webserver.
    @chmod($dest, 0664);

Four lines is probably overkill. How about a simple:

    // Set standard file permissions for webserver-generated files

Otherwise, looks RTBC.

Comment #7

douggreen CreditAttribution: douggreen commented 1 July 2007 at 14:47

File	Size
119196.patch	1.88 KB

Re-rolled with the suggested comment and a few lines were moved around so the comment makes sense. I tested the new patch on our servers with the restricted umask, and it still works.