Repeated documentation of @defgroup actions in actions.inc file:

/**
 * @defgroup actions Actions
 * @{
 * Functions that perform an action on a certain system object.
 *
 * All modules should declare their action functions to be in this group and
 * each action function should reference its configuration form, validate, and
 * submit functions using \@see. Conversely, form, validate, and submit
 * functions should reference the action function using \@see. For examples of
 * this see comment_unpublish_by_keyword_action(), which has the following in
 * its doxygen documentation:
 *
 * \@ingroup actions
 * \@see comment_unpublish_by_keyword_action_form().
 * \@see comment_unpublish_by_keyword_action_submit().
 *
 * @} End of "defgroup actions".
 */

/**
 * @defgroup actions Actions
 * @{
 * Functions that perform an action on a certain system object.
 *
 * All modules should declare their action functions to be in this group and
 * each action function should reference its configuration form, validate, and
 * submit functions using \@see. Conversely, form, validate, and submit
 * functions should reference the action function using \@see. For examples of
 * this see comment_unpublish_by_keyword_action(), which has the following in
 * its doxygen documentation:
 *
 * \@ingroup actions
 * \@see comment_unpublish_by_keyword_action_form().
 * \@see comment_unpublish_by_keyword_action_submit().
 *
 * @} End of "defgroup actions".
 */
Files: 
CommentFileSizeAuthor
#9 Repeated-documentation-actions-1190846-1.patch1.01 KBninizik
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es). View
#5 Repeated- documentation -actions-1190846-1.patch1.01 KBninizik
FAILED: [[SimpleTest]]: [MySQL] Fetch test patch: failed to retrieve [Repeated- documentation -actions-1190846-1.patch] from [drupal.org]. View

Comments

jhodgdon’s picture

Issue tags: +Novice

Huh. I wonder how that happened? It looks like the two docblocks are identical, so one of them should just be removed. Good project for a novice patch contributor. Not a problem in Drupal 7/8 either.

jvsouto’s picture

The two docblocks are identical
I also wonder how this happened

ninizik’s picture

Assigned: jvsouto » ninizik
xjm’s picture

Tracking to review a patch if one is submitted.

ninizik’s picture

Status: Active » Needs review
FileSize
1.01 KB
FAILED: [[SimpleTest]]: [MySQL] Fetch test patch: failed to retrieve [Repeated- documentation -actions-1190846-1.patch] from [drupal.org]. View

First patch ever. Scared to death because I could make a mistake. ( Not even sure about this post and issue settings)

Status: Needs review » Needs work

The last submitted patch, Repeated- documentation -actions-1190846-1.patch, failed testing.

ninizik’s picture

I don't know what's wrong. I uploaded the patch ( I also use Git to create the patch) with the file attachment form.

xjm’s picture

Try getting rid of the spaces in the patch name. :) Then when you re-upload it, you can set it back to Needs Review again for testbot to test it.

ninizik’s picture

Status: Needs work » Needs review
FileSize
1.01 KB
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es). View

Let's try again.

xjm’s picture

Status: Needs review » Reviewed & tested by the community

Looks perfect! Thanks.

jhodgdon’s picture

Thanks for taking the time to learn how to make patches, and for making this patch! As a reminder, this is Drupal 6 only (it is not a problem in Drupal 7/8).

ninizik’s picture

Step by step.... so what is the next step? ;)
Change the status ?

xjm’s picture

@ninizik: I reviewed the patch and set it to RTBC, and @jhodgdon (the docs maintainer) signed off on it. So we are done with the issue, and now it's up to the branch maintainer to commit it. :)

ninizik’s picture

So now, I can find another patch for another issue :) Thanks a lot for your help !!

jhodgdon’s picture

@ninizik: if you want to work on an issue with higher impact and faster commits, try Drupal 7/8 issues (hint, hint). :)

xjm’s picture

She's already working on a D8 one. ;)

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed, pushed.

Automatically closed -- issue fixed for 2 weeks with no activity.

jvsouto’s picture