Remove $js_settings in views_plugin_exposed_form.inc (D7 port) [#1188132]

...used in views_plugin_exposed_form.inc

    if (!empty($form_state['js settings'])) {
      $this->view->js_settings = $form_state['js settings'];
    }

Comment	File	Size	Author
#5	removed-js-settings-1188132-0.patch	2.02 KB	David Hernández
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

merlinofchaos CreditAttribution: merlinofchaos commented 14 June 2011 at 16:19

$form_state['js settings'] is no longer needed in D7, but probably hasn't been fully removed in the port.

Comment #2

neoglez CreditAttribution: neoglez commented 16 June 2011 at 13:42

Title:

Missing var $js_settings declaration in view class

» Remove/replace $js_settings in views_plugin_exposed_form.inc (D7 port)

Maybe this should not reference a file in particular? or is OK so to work (& commit) in a more modular way?

Comment #3

merlinofchaos CreditAttribution: merlinofchaos commented 16 June 2011 at 14:33

Title:

Remove/replace $js_settings in views_plugin_exposed_form.inc (D7 port)

» Remove $js_settings in views_plugin_exposed_form.inc (D7 port)

js_settings was used in D6 but the D7 ajax framework actually doesn't need it because drupal_add_js works across AJAX requests. It was a hack. It should be completely removed from D7.

Comment #4

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 18 June 2011 at 10:33

Other occurences of "js settings"

$ grep -r -n "js settings" *
includes/admin.inc:2423:    if (!empty($form_state['js settings']) && is_array($form_state['js settings'])) {
includes/admin.inc:2424:      $form_state['js settings'] = array_merge($form_state['js settings'], $form['#js']);
includes/admin.inc:2427:      $form_state['js settings'] = $form['#js'];
includes/ajax.inc:249:    if (!empty($form_state['js settings'])) {
includes/ajax.inc:250:      $commands[] = ajax_command_settings($form_state['js settings']);
plugins/views_plugin_exposed_form.inc:137:    if (!empty($form_state['js settings'])) {
plugins/views_plugin_exposed_form.inc:138:      $this->view->js_settings = $form_state['js settings'];