As discussed it would be great to have comments an explicit relationship from node, because that's not what people want to use most of the times.

CommentFileSizeAuthor
#1 1187444-comments-explicit.patch1.15 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1187444-comments-explicit.patch1.15 KB

Here is a patch

merlinofchaos’s picture

merlinofchaos commented

This breaks upgrades for people who are relying on this. How do we address that?

Maybe we don't care because it's probably not a great view if it's built this way.

merlinofchaos’s picture

merlinofchaos commented 
+    'help' => t('Brings in all comments of the node. Most time you should better use comment as base table'),

How about:

+    'help' => t('Relate all comments on the node. This will create 1 duplicate record for every comment. Usually if you need this it is better to create a comment view.'),
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Got commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.