Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The patch will let Proximity/Distance field to use the latitude and longitude from the distance argument as the origin.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | argument_origin-1187044-3.patch | 1.62 KB | edxxu |
| #1 | argument_origin-1187044-1.patch | 1.47 KB | edxxu |
Comments
Comment #1
edxxu CreditAttribution: edxxu commentedPlease review the patch!
Comment #2
bdragon CreditAttribution: bdragon commentedA) The spacing of the second patch band doesn't follow the coding standards. ( http://drupal.org/coding-standards )
B) You can't assume it will be in $view->args[0]. You have to determine which argument is the right one first, in case the view has been configured with other arguments in front of the proximity/distance one.
Comment #3
edxxu CreditAttribution: edxxu commentedPlease review the patch,thanks!
Comment #4
bdragon CreditAttribution: bdragon commentedSorry about the wait!
Committed to 7.x-3.x and 7.x-4.x, thanks!
ff9c5b885743408e6219c1c01e22e4fe48eadd25
5c93a17f220d5e129a1483efc2fe93c35d769578
Note that there is a zipcode mode the argument can be in as well, and it doesn't handle this. But I wanted to get this patch in so skyred is happy ;)
Thanks.
--Brandon
Comment #6
skyredwangCan you also commit to 6.x-3.x, please?
Comment #7
bdragon CreditAttribution: bdragon commentedskyredwang told me in irc that it was actually meant for 6.x originally.
Committed there too.
81ac6d4d99c1e22954edb1ffbd607166a22a7831