The patch will let Proximity/Distance field to use the latitude and longitude from the distance argument as the origin.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

edxxu’s picture

Please review the patch!

bdragon’s picture

Status: Needs review » Needs work

A) The spacing of the second patch band doesn't follow the coding standards. ( http://drupal.org/coding-standards )

B) You can't assume it will be in $view->args[0]. You have to determine which argument is the right one first, in case the view has been configured with other arguments in front of the proximity/distance one.

edxxu’s picture

Status: Needs work » Needs review
FileSize
1.62 KB

Please review the patch,thanks!

bdragon’s picture

Status: Needs review » Fixed

Sorry about the wait!

Committed to 7.x-3.x and 7.x-4.x, thanks!
ff9c5b885743408e6219c1c01e22e4fe48eadd25
5c93a17f220d5e129a1483efc2fe93c35d769578

Note that there is a zipcode mode the argument can be in as well, and it doesn't handle this. But I wanted to get this patch in so skyred is happy ;)

Thanks.
--Brandon

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

skyredwang’s picture

Status: Closed (fixed) » Reviewed & tested by the community

Can you also commit to 6.x-3.x, please?

bdragon’s picture

Status: Reviewed & tested by the community » Fixed

skyredwang told me in irc that it was actually meant for 6.x originally.
Committed there too.
81ac6d4d99c1e22954edb1ffbd607166a22a7831

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.