Right now the code in view::render() uses the following invocation order for pre_render:
* exposed_form::pre_render
* style_plugin::pre_render
* hook_views_pre_render
* theme_views_pre_render
* field::pre_render
In order to simplify Views Bulk Operations and other add-ons that rely on pre_render to do their work, it would really make life easier to have the hook_views_pre_render called last, and preferably the style_plugin::pre_render called after the fields. The idea is that some fields change their data during pre_render, and the style plugin needs to adjust itself to these changes.
Patch to follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | Screen shot 2012-01-18 at 13.09.26.png | 37 KB | kenorb |
| #1 | views-pre_render-1186272-1.patch | 1.32 KB | infojunkie |
Comments
Comment #1
infojunkieComment #2
merlinofchaos commentedDoes this patch apply to 7.x as well? If so I'm not against this. We need to doublecheck to see if the order here has been documented and, if so, keep the documentation in sync. I don't think it actually has been, though.
Comment #3
infojunkieThe patch also applies to 7.x-3.x with offset 100 lines. I'll also check the documentation. Thanks!
Comment #4
infojunkieCouldn't find any explicit mention of the pre_render order in docs or code comments.
Comment #5
infojunkieFYI, this patch also applies to 6.x-2.x. It would be really neat if it could be applied there too!
Comment #6
merlinofchaos commentedIt will probably not be added to the 2.x branch unless there's a critical need.
Comment #7
infojunkieFair enough. I'm sure you're anxious to move everyone away from 2.x anyway!
Comment #8
thebuckst0p commentedSeeing as this apparently relates to #1077260: Unable to select rows for D6, this would be great to see committed.
Comment #9
dawehnerGreat this patch applied to both 6.x-3.x and 7.x-3.x so committed to both.
@infojunkie Thanks for writing this patch!
Comment #11
kenorb commentedThanks for fixing it.
But unfortunately I've this problem with 6.x-2.16
Exactly with VBO #1151310: Row selections are lost - Confirmation page shows "You selected the following 0 rows"
With patch it does work.