In connection with my next issue, i see, the latest dev you try to fix page titles translation problem. It's nice, but not so good.

drupal_set_title(t($title));

First, this without check_plain() is insecure.
Second, raw user input doesn't recommend to use with t(). We discussed this with Bálint Kléri, but can't figured user friendly and "drupalish" way together.

The correct workflow should be use i18n_variables in this case. Or enable use the original page title generation, this is another issue, I'm writing.

CommentFileSizeAuthor
#7 nodeformsettings-translate-title-1182188-7.patch1.41 KBosopolar
#6 nodeformsettings-1182188-6.patch1.44 KBachton

Comments

szantog’s picture

szantog commented

The related issue: #1182192: Page titles should be optional, not required.

lelizondo’s picture

lelizondo commented

Yeah, the right way to do this apparently is with: 

<?php check_plain(t($text_here)); ?>
szantog’s picture

szantog commented
Title: Text variables translation » Page title translation

No, i'm afraid, this isn't the right way:
http://groups.drupal.org/node/15177
http://hojtsy.hu/blog/2011-may-19/drupals-multilingual-problem-why-t-wro...

szantog’s picture

szantog commented
Title: Page title translation » Text variables translation

And the same problem with submit button text:

function nodeformsettings_elements_default() {
  return array(
    ...
    'nfs_submit' => t('Submit);
    ...
  )
}

Default value in t() is completely wrong, when I submit the node settings form.

nfs_submit value in english: Submit
nfs_submit value in hungarian: Beküldés

If I edit the node type form in hungarian langauage, i get the default value from t(). In this case 'Beküldés'. I save the node type settings form, the variable value would be saved as 'Beküldés'.
Then print out trough another t() on node add/edit form, the wrong hungarian text will be inserted as translation default text.

atlea’s picture

atlea commented
Title: Page title translation » Text variables translation

Hi,

I noticed my locales_source filling up with node titles after enabling this module (7.x). Running t() on user input is plain WRONG. Why would you want to translate the title anyway?

    $title = strtr($settings['nfs_title_edit'], $replace_pairs);
    drupal_set_title(t($title));

should probably be

    $title = strtr(t($settings['nfs_title_edit']), $replace_pairs);
    drupal_set_title($title);

??

achton’s picture

achton
Location Denmark
commented
Version: 6.x-2.x-dev » 6.x-2.0
StatusFileSize
new nodeformsettings-1182188-6.patch1.44 KB

Here is my take on this (patched against 2.0 release, sorry).

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Version: 6.x-2.0 » 6.x-2.x-dev
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new nodeformsettings-translate-title-1182188-7.patch1.41 KB

Patch for current dev. Practically the same as in #7, but without strtolower. So it's almost RTBC ;)

kssundar’s picture

kssundar commented
Status: Needs review » Fixed

Ported to 6.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.