Usability of new grouping feature [#1179346]

I've been filtering out nodes that share the same node reference via a custom module and hook_views_pre_render but while this works, it doesn't seem particularly elegant.

So I started looking at the new grouping feature in 3.x. I've read this issue #1043772: Setting 'Use grouping' to 'Yes' applies Group settings "cog" to every field, relationship, argument, sort, and filter but it didn't really clear things up.

What I'm struggling with is why "Group Settings" is added to filter criteria, sort criteria and relationships, rather than just the fields in a view? Also shouldn't there be a "Group Type > None" option in the Group Settings?

thanks

Comment	File	Size	Author
#10	1179346-rename-groupby-aggregation.patch	4.51 KB	dawehner
#10	aggregate1.png	26.33 KB	dawehner
#10	aggregate2.png	43.57 KB	dawehner
#9	1179346-groupby.patch	1013 bytes	dawehner

Comments

Comment #1

dawehner

German

commented 5 June 2011 at 17:20

The sql standard afaik says: A field in sql can be either part of the groupby or part of an aggregate function like count()

Comment #2

Anonymous (not verified) commented 5 June 2011 at 19:47

OK but why would there need to be Group Settings for filters, sorts and relationships?

Comment #3

dawehner

German

commented 5 June 2011 at 20:07

An example for filters:

* Display all users with more then 10 nodes.

Comment #4

merlinofchaos commented 13 June 2011 at 21:07

We need to do some documentation work ont his feature.

Plus, I've been thinking that we should rename it from "Grouping" to "Aggregation" and explain in the help text that it enables the GROUP BY portion of a query and will aggregate multiple records into one, grouping by unaggregated fields.

Thoughts?