As the subject suggest, field_view_field() does not pass language to hook_field_attach_view() implementations as field_attach_view() does.

CommentFileSizeAuthor
#6 tf-1178480-1.patch458 bytesplach
#1 tf-1178480-1.patch458 bytesplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
Issue tags: +Quick fix
StatusFileSize
new tf-1178480-1.patch458 bytes

Status: Needs review » Needs work

The last submitted patch, tf-1178480-1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: -Quick fix, -translatable fields, -Needs backport to D7

#1: tf-1178480-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Quick fix, +translatable fields, +Needs backport to D7

The last submitted patch, tf-1178480-1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
StatusFileSize
new tf-1178480-1.patch458 bytes

retest

Status: Needs review » Needs work
Issue tags: -Quick fix, -translatable fields, -Needs backport to D7

The last submitted patch, tf-1178480-1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
Issue tags: +Quick fix, +translatable fields, +Needs backport to D7

#6: tf-1178480-1.patch queued for re-testing.

No failures on my box.

damien tournoud’s picture

damien tournoud commented
Title: field_view_field() does not pass language to hook_field_attach_view() implementations » field_view_field() does not pass language to hook_field_attach_view_alter() implementations
Status: Needs review » Reviewed & tested by the community

Indeed. This is a big hurdle for language-dependent translations.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

If this is a bug, we ought to be able to add a test that illustrates it, no?

swentel’s picture

swentel commented
Issue summary: View changes
Status: Needs work » Closed (duplicate)

This is being fixed in #1823306: Language code is missing from $context when hook_field_attach_view_alter() is invoked from field_view_field()