Add support to sqlite for char:normal type [#1177284]

Problem/Motivation

The schema API documentation lists "char:normal" as an available data type. However, this data type is currently not supported for sqlite, so schemas using this data type will not be installed properly.

Proposed resolution

Map char:normal to the SQLite CHAR data type. #1177284-3: Add support to sqlite for char:normal type implements this fix.

Remaining tasks

Once patch is committed, update http://drupal.org/node/159605 to indicate the type is now supported. (It was changed to "unsupported" after this issue was reported.)

User interface changes

None.

API changes

None.

Original report by @Bobík

After enable the module you can see this messages:

Notice: Undefined index: char:normal ve funkci DatabaseSchema_sqlite->processField() (řádek: 127 v souboru /Users/Bobik/Sites/drupal-7/includes/database/sqlite/schema.inc).
Notice: Undefined index: char:normal ve funkci DatabaseSchema_sqlite->processField() (řádek: 127 v souboru /Users/Bobik/Sites/drupal-7/includes/database/sqlite/schema.inc).
Notice: Undefined index: char:normal ve funkci DatabaseSchema_sqlite->processField() (řádek: 127 v souboru /Users/Bobik/Sites/drupal-7/includes/database/sqlite/schema.inc).
Notice: Undefined index: char:normal ve funkci DatabaseSchema_sqlite->processField() (řádek: 127 v souboru /Users/Bobik/Sites/drupal-7/includes/database/sqlite/schema.inc).

Comment	File	Size	Author
#3	drupal-1177284.patch	1012 bytes	ohnobinki
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ohnobinki CreditAttribution: ohnobinki commented 29 June 2011 at 04:10

+ (seeing a similar thing with ubercart's uc_store schema.)

Comment #2

ohnobinki CreditAttribution: ohnobinki commented 29 June 2011 at 04:56

Title:	Notices after install	» Add support to sqlite for char:normal type
Project:	OAuth 1.0	» Drupal core
Version:	7.x-3.x-dev	» 8.x-dev
Component:	Code	» sqlite database
Issue tags:		+sqlite

Data Types documents the availability of a char:normal type. DatabaseSchema_sqlite::getFieldTypeMap() does not yet support this in drupal7 nor drupal8.

Both the modules OAuth (_oauth_common_consumer_schema()) and ubercart's uc_store module (uc_store_schema()) make use of char:normal.

Errors from uc_store's uc_store_schema():

Notice: Undefined index: char:normal in DatabaseSchema_sqlite->processField() (line 122 of /var/www/localhost/htdocs/drupal/includes/database/sqlite/schema.inc).
Notice: Undefined index: char:normal in DatabaseSchema_sqlite->processField() (line 122 of /var/www/localhost/htdocs/drupal/includes/database/sqlite/schema.inc).
PDOException: SQLSTATE[HY000]: General error: 1 near "(": syntax error: CREATE TABLE {uc_countries} ( country_id INTEGER NOT NULL CHECK (country_id>= 0), country_name VARCHAR(255) NOT NULL DEFAULT '', country_iso_code_2 (2) NOT NULL DEFAULT '', country_iso_code_3 (3) NOT NULL DEFAULT '', version INTEGER NOT NULL DEFAULT 0, PRIMARY KEY (country_id) ); ; Array ( ) in db_create_table() (line 2592 of /var/www/localhost/htdocs/drupal/includes/database/database.inc)

I believe that mapping this type onto 'CHAR' makes the most sense and will add a patch which does that. This bug affects both drupal-8.x and drupal-7.x.