Hi
Working on upgrading av D6 site to 7 and bumped into this issue and I'm not able to resolve without some assistance. Trying to edit/clone/export some of the views give me a WSOD and:
PHP Fatal error: Call to a member function get_option() on a non-object in /drupal-7.2/sites/all/modules/views/includes/admin.inc on line 1063

- Drupal 6.22 -> Drupal 7.2
- Views latest dev.
cTools - beta 1
PHP 5.3.x

I think the problem is related to Views Attach (http://drupal.org/project/views_attach) used back in views 6.3.x before EVA came along, at least these views are the one blowing up on edit/clone/export.

As a non OOP ninja (PHP objects, patterns and Practice is still gathering dust in my shelf), do I have a little problem working out, how where to start digging. Is the problem that $handler is undefined? Yeah, I'm a bit lot, but willing to learn :)

Comments

dawehner’s picture

Status: Active » Postponed (maintainer needs more info)

Can you give us some help to reproduce the problem? This would be great.

steinmb’s picture

Status: Postponed (maintainer needs more info) » Active

Hi, thanx for your quick reply :)
Went back to D6 and removed the node attach displays from the exploding views, and migrated one more time. No they do not blow up so I think to reproduce you could:
- Use D6 and CCK, Views 6.2.x + views attach
- Create a view that picks up a few CCK fields, I used tables layout (prob. not important)
- Create a display that use, views attach and attach this view to a node on full node render.
- Verify that this is working
- Turn off Views, CCK, views attach etc. and run your migration to D7 and Views 7.3.x
- Edit the view that used views attach and boom!

dawehner’s picture

Well you probably have to wait until views_attach is ported.

Not sure whether views should try to work around the problem, because that's actually something which shows you clearly that you have somehow a problem on your site.

swentel’s picture

Also, Views attach is deprecated for http://drupal.org/project/eva

steinmb’s picture

Yeah, that is the core of the problem. There will never be a D7 version of views attach and, from what I know, never a migration path. I'm OK with recreating views attach in EVA, but it is hard to do, when Views blows up when we try to do just that.

merlinofchaos’s picture

Priority: Normal » Major

Well, in any case we shoudln't WSOD. I suspect this means that for invalid displays the new admin is crashing. I know the old UI checked for that stuff, but some of those checks probably got lost in updates. WSODs like this are at least major.

dawehner’s picture

Status: Active » Needs review
StatusFileSize
new1.06 KB

Here is a patch which adds a little help text.

merlinofchaos’s picture

There's a typo in the text, initialize is misspelled.

The text we usually use is something like "Invalid/missing display handler" -- might want to search and model it to be the same.

merlinofchaos’s picture

This looks like the wording we're currently using:

t('Display plugin @plugin is not available.', array('@plugin' => $display->display_plugin)), 'error');
dawehner’s picture

Here is a new patch and a screenshot attached.

The -with-unset is for testing.

dawehner’s picture

Mh okay, the default one also has the unset. So takes care when you commit.

dawehner’s picture

Status: Needs review » Fixed

Commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.