The PHP Mail_mimeDecode package has been split off from the PHP Mail_Mime package (see . Since the decode functions are used in the Drupal Mail_Mime package, the warnings generated when the PHP packages are not found now need to say that both of them need to be installed. As it is now, someone can install Drupal Mime_Mail, get the message, install PHP Mime_Mail, and then be frustrated when the Drupal Mime_Mail still can't be enabled.

CommentFileSizeAuthor
#5 document_both_pear_modules-1173620-5.patch2.33 KBben coleman

Comments

ben coleman’s picture

ben coleman commented

Ah, I see that the install instructions specify using 'pear install -a Mail_Mime', which will get Mail_mimeDecode as a dependency. I still think that some indication that both Pear modules are needed might be a good thing.

pillarsdotnet’s picture

pillarsdotnet commented
Component: Code » Documentation
Assigned: Unassigned » pillarsdotnet
Status: Active » Needs work

Can you roll a patch?

ben coleman’s picture

ben coleman commented

I'll try to roll something as soon as I can.

pillarsdotnet’s picture

pillarsdotnet commented

Note that README.markdown and API.markdown are the source files; the .html and .txt files are auto-generated.

ben coleman’s picture

ben coleman commented
Status: Needs work » Needs review
StatusFileSize
new document_both_pear_modules-1173620-5.patch2.33 KB

Attached is a proposed patch for this. I've changed both the README and the warning message in mailmime.module.

pillarsdotnet’s picture

pillarsdotnet commented
Status: Needs review » Fixed

Actually, the required files are listed in the Requirements section:

  1. Mail/mime.php
  2. Mail/mimeDecode.php
  3. Mail/mimePart.php
  4. PEAR.php
  5. PEAR5.php

So there are actually (parts of) five PEAR modules required. Listing just two is nearly as misleading as listing one.

Also, according to the documentation on php.pear.net and inside the downloaded files, all three mail classes are part of the same Mail_Mime package.

~# egrep '@(link|package) ' /usr/share/php/Mail/mime.php /usr/share/php/Mail/mimePart.php /usr/share/php/Mail/mimeDecode.php 
/usr/share/php/Mail/mime.php: * @package   Mail_Mime
/usr/share/php/Mail/mime.php: * @link      http://pear.php.net/package/Mail_mime
/usr/share/php/Mail/mime.php: * @package   Mail_Mime
/usr/share/php/Mail/mime.php: * @link      http://pear.php.net/package/Mail_mime
/usr/share/php/Mail/mimePart.php: * @package   Mail_Mime
/usr/share/php/Mail/mimePart.php: * @link      http://pear.php.net/package/Mail_mime
/usr/share/php/Mail/mimePart.php: * @package   Mail_Mime
/usr/share/php/Mail/mimePart.php: * @link      http://pear.php.net/package/Mail_mime
/usr/share/php/Mail/mimeDecode.php: * @package    Mail_Mime
/usr/share/php/Mail/mimeDecode.php: * @link       http://pear.php.net/package/Mail_mime
/usr/share/php/Mail/mimeDecode.php: * @package    Mail_Mime
/usr/share/php/Mail/mimeDecode.php: * @link       http://pear.php.net/package/Mail_mime

It's true that you can download two of the three separately, but I'm also using parts of the Mail_mimePart class, which, (afaict) cannot be downloaded separately.

Soo.....

Modified and applied to -dev and (partially) to the latest release. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.