Closed (fixed)
Project:
DHTML Menu
Version:
5.x-0.x-dev
Component:
User Interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Feb 2007 at 00:21 UTC
Updated:
26 Jul 2007 at 07:45 UTC
Jump to comment: Most recent file
Comments
Comment #1
Wuk commentedMaybe there is a better way to do this, but it is working for me.
Comment #2
mine@subnet142.com commentedHi, the patch works for me. Many thanks. However, will it be merged to the module soon? (Sorry for my ignorance of the code review/merge practice of the Drupal teams.)
Comment #3
dmetzcher commentedI actually like the fact that it's named "Navigation" now. I added a new block with some user account features in it, and the name of the user currently logged in is displayed in my new block. Is it possible, when you release the next version, that you make it configurable so that we can choose to make the block title the username OR something else (like "Navigation") that we pick ourselves?
Comment #4
merlinofchaos commentedI think this probably should be a setting. Maybe our new DHTML Menu helper guy will be able to implement a setting for this.
Comment #5
cburschkaBlocks can already get arbitrary static names through the block settings. In fact, I did this for my normal Navigation menu before installing this, since I don't like the username there either. This module could title its navigation block the same as as menu.module does, without duplicating the options of the block interface.
In fact, since the DHTML Menu block is meant to replace the existing menu blocks, this would improve consistency.
Rerolling this patch against HEAD without modification and setting as RTBC. I think this can go in soon, unless you have any objections, merlin?
Comment #6
cburschkaOuch! My first patch, and I nearly missed a bug. But I didn't.
When you're logged out, the normal Navigation menu is titled "Navigation". The last version of this patch removes the title of the DHTML Menu when you're logged out.
This patch adds an extra check for
$user->uid > 0before trying to use the username.Comment #7
cburschkaCommitted to HEAD and DRUPAL-5.
Comment #8
(not verified) commented