It seems a bug to me.
My web server runs drupal 5.1 and subscriptions module 5.x-1.x-dev, but the same happens with 5.x-1.4
Notification e-mails are generated with weird From:, Reply-To: and Errors-To: fields.
Read below (copied/pasted from source, replaced actual domain with example.it):
Errors-To: =?UTF-8?B?RnJvbTogYXNzaXN0ZW56YS13ZWJAbmV3Y29tc3JsLml0ClJlcGx5LXRvOiBhc3M=?=@example.it,
=?UTF-8?B?aXN0ZW56YS13ZWJAbmV3Y29tc3JsLml0ClgtTWFpbGVyOiBEcnVwYWwKUmV0dXI=?=@example.it,
=?UTF-8?B?bi1wYXRoOiBhc3Npc3RlbnphLXdlYkBuZXdjb21zcmwuaXQKRXJyb3JzLXRvOiA=?=@example.it,
=?UTF-8?B?YXNzaXN0ZW56YS13ZWJAbmV3Y29tc3JsLml0?=@guardian.newcomsrl.it
Reply-To: =?UTF-8?B?RnJvbTogYXNzaXN0ZW56YS13ZWJAbmV3Y29tc3JsLml0ClJlcGx5LXRvOiBhc3M=?=@example.it,
=?UTF-8?B?aXN0ZW56YS13ZWJAbmV3Y29tc3JsLml0ClgtTWFpbGVyOiBEcnVwYWwKUmV0dXI=?=@example.it,
=?UTF-8?B?bi1wYXRoOiBhc3Npc3RlbnphLXdlYkBuZXdjb21zcmwuaXQKRXJyb3JzLXRvOiA=?=@example.it,
=?UTF-8?B?YXNzaXN0ZW56YS13ZWJAbmV3Y29tc3JsLml0?=@example.it
From: =?UTF-8?B?RnJvbTogYXNzaXN0ZW56YS13ZWJAbmV3Y29tc3JsLml0ClJlcGx5LXRvOiBhc3M=?=@example.it,
=?UTF-8?B?aXN0ZW56YS13ZWJAbmV3Y29tc3JsLml0ClgtTWFpbGVyOiBEcnVwYWwKUmV0dXI=?=@example.it,
=?UTF-8?B?bi1wYXRoOiBhc3Npc3RlbnphLXdlYkBuZXdjb21zcmwuaXQKRXJyb3JzLXRvOiA=?=@example.it,
=?UTF-8?B?YXNzaXN0ZW56YS13ZWJAbmV3Y29tc3JsLml0?=@example.it
E-mail clients cannot parse properly such headers, and show almost non-sense content in header data (e.g., From: field is invalid, a very long string with fragments of random header strings).
The body part, instead, is fine.
This is a serious issue, to me.
Hope you can help me fix the problem.
--
Gabriele
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | subscriptions_sendmail_patch_1.txt | 1.67 KB | mindless |
| #8 | subscriptions.module.txt | 55.34 KB | gabble |
| #5 | subscriptions_sendmail_patch_0.txt | 1.72 KB | mindless |
| #4 | subscriptions_sendmail_patch.txt | 1.73 KB | mindless |
Comments
Comment #1
gabble commentedCan anybody confirm the issue?? :-(
Comment #2
mindless commentedyes, the current code is passing $headers to the drupal_mail $from parameter, as I mentioned here.
Comment #3
gabble commentedThanks for your reply!!
Any chances it will be fixed soon, or is there a patch available somewhere?
--
Gabriele
Comment #4
mindless commentedI don't have CVS access for this module, so I can't fix it myself.. but here is a patch.
Comment #5
mindless commentedoops, $headers is an array not string.. also X-Mailer: Drupal is added by default in drupal_mail.
corrected patch attached.
Comment #6
gabble commentedIt works flawlessly!
Thanks for your time! :-)
--
Gabriele
Comment #7
neubreed commentedWhat version do I apply this patch to ? I've tried it on both the cvs and 1.4 versions but I get:
File to patch: subscriptions/subscriptions.module
patching file subscriptions/subscriptions.module
Hunk #1 FAILED at 434.
Hunk #2 FAILED at 536.
Hunk #3 FAILED at 1474.
Hunk #4 FAILED at 1489.
4 out of 4 hunks FAILED -- saving rejects to file subscriptions/subscriptions.module.rej
Comment #8
gabble commentedI have patched cvs version.
Actually I made modifications manually... :-}
Removed lines with "-" and added lines with "+"
Here is the "patched" module…
Comment #9
mindless commentedThe patch is for CVS DRUPAL-5 branch.
Comment #10
psi-jack commentedThe final revision manually patched by gabble with post #8, seems to work fine for me, on Drupal 5.1. I tried various ways myself, and tried manually downloading the module from CVS, patching it myself, but there were things missing from it as well, this here, seems to work as expected.
Comment #11
mindless commentedweird, some problem with windows newlines prevented my patch from applying. the attached one should work, applying to 1.62.2.20 (current rev as of now on DRUPAL-5 branch).
Comment #12
neubreed commentedStill failing :(
Comment #13
arthurf commented5.0 branch now has this patch in place. Can folks give this a test?
Comment #14
mindless commentedComment #15
(not verified) commented