After a fresh 5.1 install in the admin interface administer > site configuration > performance the radio button near 'Disabled' for the setting 'Aggregate and compress CSS files' isn't marked as selected. If you enable the CSS preprocessor the 'Enabled' radio button is marked as selected. If deactivated the 'Disabled' radio button isn't marked selected again after submitting the settings. I have not tested if the CSS preprocessor is activated and deactivated correctly. Maybe just a small UI bug.

CommentFileSizeAuthor
#1 aggregator_default_value.patch1.32 KBneclimdul

Comments

neclimdul’s picture

neclimdul
He/Him
commented
Title: Admin interface: Bandwith optimizations » Admin interface: Default aggregator form value is improperly set
StatusFileSize
new aggregator_default_value.patch1.32 KB

Quick fix. FALSE isn't evaluating to 0, so the disabled radio button is not set. Wrapping the comparison in intval() fixes this and provides the desired behavior.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Active » Needs review
drumm’s picture

drumm
he/him
Location NY, US
commented
Version: 5.1 » 6.x-dev
Status: Needs review » Patch (to be ported)

Committed to 5.x.

Looks like this problem exists in HEAD too, but this patch does not apply there.

bart jansens’s picture

bart jansens commented
Status: Patch (to be ported) » Fixed

Already fixed in HEAD: http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/system/system.admi...

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.