Undefined offset: 1 in theme_views_mini_pager() line 847 [#1170804]

How to reproduce the warning

1) Enable error backtrace in the devel module.
2) Create a view and set the pager offset to a value larger than 0

Save and you will see a bunch of warnings.

Reason for the warning

In case that $_GET['page'] is empty only one $pager_page_array element is created:

$pager_page_array = isset($_GET['page']) ? explode(',', $_GET['page']) : array(0);

Solution

Fix the set_current_page function in views_plugin_pager_full.inc:

if(empty($pager_page_array))
  $pager_page_array = isset($_GET['page']) ? explode(',', $_GET['page']) : array();

if(!isset($pager_page_array[$this->options['id']]))
    $pager_page_array[$this->options['id']] = 0;

Comment	File	Size	Author
#5	views-pager-page-array-117080.patch	1.44 KB	smk-ka
#4	views-pager-page-array.patch	1.42 KB	jantimon
#3	views-pager-page-array.patch	1.53 KB	jantimon
#2	views-pager-page-array.patch	1.06 KB	jantimon
	views.patch.diff	696 bytes	jantimon

Comments

Comment #1

dawehner

German

commented 27 May 2011 at 17:26

Status:

Active

» Needs work

+++ b//plugins/views_plugin_pager_full.incundefined
@@ -217,7 +217,11 @@ class views_plugin_pager_full extends views_plugin_pager {
-    $pager_page_array = isset($_GET['page']) ? explode(',', $_GET['page']) : array(0);
+    if(empty($pager_page_array))
+      $pager_page_array = isset($_GET['page']) ? explode(',', $_GET['page']) : array();
+
+    if(!isset($pager_page_array[$this->options['id']]))
+        $pager_page_array[$this->options['id']] = 0;

Drupal code style set's an { for one-line patches as well

Powered by Dreditor.

Comment #2

jantimon commented 31 May 2011 at 07:59

Status	File	Size
new	views-pager-page-array.patch	1.06 KB

After further testing I recognized that the global array is changed somewhere else and somehow one element might be set to -1.
So I changed my patch to reset the $pager_page_array similar to the current implementation.