hook_menu doc should say how to pass integer arg to callbacks

I think we just need to add a small clarification to this part:

In addition to optional path arguments, the page callback and other callback functions may specify argument lists as arrays. These argument lists may contain both fixed/hard-coded argument values and integers that correspond to path components. When integers are used and the callback function is called, the corresponding path components will be substituted for the integers. That is, the integer 0 in an argument list will be replaced with the first path component, integer 1 with the second, and so on (path components are numbered starting from zero). This substitution feature allows you to re-use a callback function for several different paths.

Proposed:

In addition to optional path arguments, the page callback and other callback functions may specify argument lists as arrays. These argument lists may contain both fixed/hard-coded argument values and integers that correspond to path components. When integers are used and the callback function is called, the corresponding path components will be substituted for the integers. That is, the integer 0 in an argument list will be replaced with the first path component, integer 1 with the second, and so on (path components are numbered starting from zero). This substitution feature allows you to re-use a callback function for several different paths. To pass an integer without it being replace with its respective path component, use the string value of the integer (e.g. '1') as the argument value.

subscribe

Hm. The text reads to me as though there's about to follow an example of passing in an argument as a string, but that's not what follows:

  function mymodule_menu() {
    $items['abc/def'] = array(
      'page callback' => 'mymodule_abc_view',
      'page arguments' => array(1, 'foo'),
    );
    return $items;
  }

Should we expand the example to also include a literal '1'? Or slightly re-write the text so that the association is not so close?

Rearranged the sentence order and recreated the patch.

Looks good to me.

Perfect!

Committed to 8.x and 7.x. Thanks!

Oops.

Looks like D6 for this issue was fixed in #617424: Error in hook_menu documentation for load arguments.