Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As per a conversation with @pwolanin on IRC, there might be instances where a searcher is indexing multiple entities, either Drupal or not. Therefore it would be beneficial for each adapter to be associated with multiple types in an array as opposed to confining them to a single type.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | committers.jpg | 43.63 KB | cpliakas |
| #10 | facetapi-typo-in-legacy-support-code-1167974-10.patch | 456 bytes | das-peter |
| #7 | facetapi-1167974-7.patch | 3.03 KB | cpliakas |
Comments
Comment #1
cpliakas CreditAttribution: cpliakas commentedNote that the bundle dependency plugin has some assumptions surrounding the type that need to be broken.
Comment #2
cpliakas CreditAttribution: cpliakas commentedComment #3
cpliakas CreditAttribution: cpliakas commentedMarking as active. We need to maintain backwards compatibility for this change so that we don't have to synchronize releases with the other backends. This means that the adapter will have both "type" and "types" keys.
Comment #4
cpliakas CreditAttribution: cpliakas commentedMarking as a beta4 blocker.
Comment #5
cpliakas CreditAttribution: cpliakas commentedAdding new tag to track backwards compatible API changes. Legacy code should be removed when the module goes 1.0.
Comment #6
cpliakas CreditAttribution: cpliakas commentedChanged my mind. There are more important fixes that should be released ASAP.
Comment #7
cpliakas CreditAttribution: cpliakas commentedFirst crack at resolving this. The known issue is that the bundle is not entity aware. We really need facets that contain bundles a way to identify themselves as such.
Comment #8
cpliakas CreditAttribution: cpliakas commentedWebchick says jump, I say "how high?". http://www.webchick.net/node/89
Comment #9
cpliakas CreditAttribution: cpliakas commentedResolved in commit 9cc690e. Bundle issue posted at #1222754: Resolve assumptions in the "bundle" dependency plugin.
Comment #10
das-peter CreditAttribution: das-peter commentedJust came across an issue while playing around with the facet_api <-> search_api integration.
The code for the legacy support of the
typekey deletes the whole info array.Attached patch fixes this.
Comment #11
cpliakas CreditAttribution: cpliakas commentedOh boy. Great catch! Looks good to me.
Comment #12
cpliakas CreditAttribution: cpliakas commentedCommitted at 5be7a86.
Congrats on becoming the 5th committer to Facet API!
Thanks,
Chris