I'm trying this out today and see all the KCFinder files are in the module itself instead of /libraries directory. My reference is to: 3rd party libraries on Drupal.org here.

Hopefully this has been approved, but it's a question that probably needs asking. Looking at the code I see that at one point the files were in /libraries and then moved into the module.

Comments

Niremizov’s picture

Niremizov commented

The reason is that we are sharing session data of drupal with KCFinder, for that we made some correction of core/autoload.php. So if all KCFinder files are placed inside module it is much easyer to install it...

danyalejandro’s picture

danyalejandro commented

As Niremizov said,

Initially, we tried to not include the kcfinder's library, but ended up doing it because it needs some lines of it's code to be altered to work with Drupal (to include the Drupal session). To this date, we haven't been able to setup the module in a way that doesn't require code alteration.

Besides, the library's development has been suspended, so making a "fork" isn't out of planning in our future versions. We even got the author's permission and everything (he didn't get the drama of the situation though, no need to ask for it).

KCFinder library:

  1. Has a GPLv2 & LGPLv2 license.
  2. Needs it's code to be modified to work with Drupal (please tell us if not!).
  3. Currently, it's development has been suspended (we don't know if the case will be different in the future).
  4. Currently, the original author "does not have the time" to make any changes to the official library.
  5. The included version is a patched one (by the original author) from a forum post, that includes bugfixes. It's not the official, published version. It's "hard" to find.

I think we would be candidates for an exception.

pwolanin’s picture

pwolanin commented
Issue tags: +Legal

Larry or Gerhard should weigh in here, but sounds like a reasonable case for an exception.

The code must be licensed GPL v2+ to be on d.o, so you should add an additional line to that effect in each of the source files that has a copyright and license statement.

This diagram suggests the LGPL2 can legally be converted to GPL v2+
http://www.dwheeler.com/essays/floss-license-slide.html

If it was GPL v2 (only) you could not add it to d.o without permission of all existing copyright holders to re-license it.

danyalejandro’s picture

danyalejandro commented
Status: Active » Fixed

Now the KCFinder library is a separate download! No more legal issues I guess...

Automatically closed -- issue fixed for 2 weeks with no activity.