This is my first attempt to submit a patch. I'd welcome comments.

CommentFileSizeAuthor
#5 tables.module_drupal5.patch4.47 KBpfaocle
#4 tables.info_.txt174 bytespfaocle
tables5.patch3.94 KBJHeffner

Comments

preferred name’s picture

preferred name commented
Title: Tables filter 5 compatibilty » Valid XHTML 1.0 Strict!

search for

before the two of them.
search for

and add

after it

preferred name’s picture

preferred name commented

opps...

in the tables.module file...

search for <table and add </p> before the two of them.
search for </table> and add <p> after it

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Title: Valid XHTML 1.0 Strict! » Update for Drupal 5.0

Please don't change the issue title - it makes threads like this harder to find.

I'm just about to test this filter out in Drupal 5, and will try the patch. Many thanks, will report back soon.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
StatusFileSize
new tables.info_.txt174 bytes

First up, the .info file. Had to attach it with a .txt extension, sorry. Updated patch on the way.

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
StatusFileSize
new tables.module_drupal5.patch4.47 KB

JHeffner's patch worked a treat in the most part - muchas gracias! Just two differences in mine (aside from some formatting):

  • Why remove 'admin/help#tables'? Admittedly, its not working properly for me yet but I've left it in for now.
  • Checking whether the '$css' variable is empty is pointless, as the variable contains the result of variable_get('tables_css', drupal_get_path('module','tables'). '/tables.css'), which always returns a value even if the variable is not in the database.

The only other quibble I have with this module is why the settings are on an admin page, rather than the usual input format configuration, but I guess thats another issue.

I have this patch and info file running on two dev sites, and it seems to be fine. Please review!

TheFazz’s picture

TheFazz commented

i applied the patch to the tables HEAD CVS, but it did not appear on the modules admin list. is this supposed to happen? if so, how do i activate it?

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented

You'll need to add a file called tables.info in the /modules/tables/ folder - see comment #4.

JHeffner’s picture

JHeffner commented

Thanks.. I just grabbed your changes and it appears to be working fine.

Anonymous’s picture

Anonymous (not verified) commented

I am using this patch on Drupal 5.2, too - thanks a lot! It seems to work perfectly.

Any plans on making it available within a 5.x-branch? I guess some people have difficulties in patching it together. There is also no real alternative to this module (tried tablemanager, but too complex and different goal).

Cheers,
Stephan

ewilts’s picture

ewilts commented

This appears to be working on Drupal 5.3. The only change I had to make was that with Drupal 4.6 (where I started), the input filters did not have to be rearranged (I have bbcode embedded within a table). With Drupal 5.3, the tables filter has to have a higher weight (i.e. heavier) than the bbcode filter. Once I figured that out, my complex table displays properly.

I started with the tables-4.7.x-1.x-dev.tar.gz release and applied the patch from comment #5 to it.

Thanks to Paul and Jason for their efforts!

realityloop’s picture

realityloop commented

working on 5.7 / subscribe

Also is anyone able to add table, not to be confused with cell, alignment?

Edit:
Added Issue for table alignment: http://drupal.org/node/228218

realityloop’s picture

realityloop commented
Status: Needs review » Reviewed & tested by the community
realityloop’s picture

realityloop commented
Status: Reviewed & tested by the community » Fixed

dev release now downloadable, I will push a stable release if I get no feedback to indicate otherwise in a week or two

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.