While working on another server responses assertion, I realized that we don't ensure identical/consistent server responses for the local fake testing server.

99% of this patch was trivial and took only a few minutes, but upon attempting to fix the last test failure, I ran into a problem and quite interesting question about logical code execution order that I'm unable to answer myself currently. Documented as @todo in this patch.

CommentFileSizeAuthor
#2 mollom.post-body-empty.2.patch3.21 KBsun
mollom.local-responses.0.patch3.38 KBsun

Comments

Status: Needs review » Needs work

The last submitted patch, mollom.local-responses.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new mollom.post-body-empty.2.patch3.21 KB

Resolved it.

Closely related to #446994: Implement a generic Mollom PHP class, so I'd like to commit this ASAP.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Alright, as this only pertains to tests and it helps me to make progress, I've committed #2 to master and also a backport to 6.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 50621ed on master, fai6, 8.x-2.x, fbajs, actions by sun: 
    Issue #1162892 by sun: Ensure that local fake testing server responses...

  • Commit 50621ed on master, fai6, 8.x-2.x, fbajs, actions by sun: 
    Issue #1162892 by sun: Ensure that local fake testing server responses...