Comments

rszrama’s picture

Status: Active » Fixed

Committed, thanks! And just so I know, is there an expectation with the Italian postal service that a province be selected?

ronald_istos’s picture

Thanks! And yes they expect the province to be there although the postcode is technically unique and enough to identify province/city pair

rszrama’s picture

Great, thanks for getting this in to us. : )

I see there are a bunch more waiting to be added, too. I guess they aren't tweeting about their patches. ^_^

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

aturetta’s picture

Priority: Normal » Critical
Status: Closed (fixed) » Needs review
StatusFileSize
new410 bytes

The patch committed did not add the italian include file to the info's files section. As a result the module gives now a WSOD if the default language is italian.

Also, please close #1062166: Italian provinces which is almost a duplicate of this one, but this one has slightly better names for some italian provinces.

aturetta’s picture

StatusFileSize
new1.29 KB

While I'm at it, I corrected some misspelled province names. Please use this patch and not #5.

aturetta’s picture

StatusFileSize
new1.29 KB

It seems # is not a valid character for filenames in issues..... sorry

aturetta’s picture

StatusFileSize
new1.29 KB

OMG, I hope this time all is good. The previous one was not UTF-8.....

rszrama’s picture

Status: Needs review » Fixed

Fixed, thanks for sticking with this.

aturetta’s picture

Priority: Critical » Normal
Status: Fixed » Needs review
StatusFileSize
new849 bytes

Followup.

Add a customized formatter for Italian.

The attached file should be renamed as .tpl.php and committed to the theme directory.

aturetta’s picture

Assigned: ronald_istos » Unassigned

Ping

aturetta’s picture

StatusFileSize
new1 KB

Re-submitting as patch, maybe it is easier.

damien tournoud’s picture

Status: Needs review » Closed (won't fix)

The -reloaded branch has been merged. Tested by aturetta yesterday, this doesn't appear to be needed anymore.