CommentFileSizeAuthor
#3 user.api_.php_.patch613 bytesTR
user.api_.php_.patch462 bytesTR
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mr.baileys’s picture

Status: Needs review » Reviewed & tested by the community

Good catch, and the patch is RTBC.

One additional change I'd consider making is changing the query in the example to SELECT uid, foo FROM {my_table} WHERE uid IN (:uids) so it's clearer where foo comes from.

mr.baileys’s picture

Issue tags: +Needs backport to D7
TR’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
613 bytes

Re: #1
I thought the same thing, so let's just do it. Here's a revised patch.

mr.baileys’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.