Currently the Fields section has a dropbutton with these options
- add
- sort
- delete

Selecting either "sort" or "delete" shows an overlay with the ability to rearrange the fields or delete them. The only difference is the h2 title of the overlay. So having 2 distinct options in this dropbutton is unnecessary.

I would suggest just two options would be cleaner
- add
- edit

then the displayed overlay could have an h2 title of "Edit fields" rather than the current "Rearrange fields" and "Delete fields"

CommentFileSizeAuthor
#6 1150652-simplilfy-dropdown.patch7.47 KBdawehner
#5 1150652-simplilfy-dropdown.patch7.99 KBdawehner
#3 1150652-simplilfy-dropdown.patch7.47 KBdawehner

Comments

merlinofchaos’s picture

merlinofchaos commented
Category: feature » task

Yeah, I'm not sure what happened there. Jeff's original design wanted them to be distinct, though I fought against that.

I think we should just remove one of them. I personally never understood why to make them separate when they are so fundamentally similar.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

sub

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1150652-simplilfy-dropdown.patch7.47 KB

Here is a patch for it.

All things are still working from my perspective.
Renamed sort to rearrange.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work 
+++ b/includes/admin.incundefined
@@ -2126,7 +2126,7 @@ function views_ui_edit_form_get_bucket($type, $view, $display) {
-      $rearrange_text = t('Sort');
+      $rearrange_text = t('rearrange');

This has text-transform: lowercase applied anyway, so to match the rest it should be "Rearrange".

Otherwise it looks great to me.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 1150652-simplilfy-dropdown.patch7.99 KB

Update the patch

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 1150652-simplilfy-dropdown.patch7.47 KB

Update patch something between was added.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Tested, works great. Much clearer and easier.

Anonymous’s picture

Anonymous (not verified) commented

Is "Rearrange" a broad enough term for the page that is shown? I know you can delete fields by clicking into them from the top level but personally "Rearrange" indicates to me the ability to reorder fields but doesn't give me a clue that it is also a quick way to delete fields.

I understand that "Rearrange" is used on other dropbuttons but would question whether these would also be better described as "Edit"?

bojanz’s picture

bojanz commented

To me, Edit is the operation that I do when I click on a field. Rearrange is better. No solution will be clear enough, in any case...

merlinofchaos’s picture

merlinofchaos commented

I agree, 'Edit' is a step backward.

Anonymous’s picture

Anonymous (not verified) commented

But what if you only have one field? The options previously were
- add
- delete

will it now be
- add
- rearrange

dawehner’s picture

dawehner
Primary language German
commented

Rearrange will be always availible if you have more than one, this is part of the patch.

dawehner’s picture

dawehner
Primary language German
commented

Rearrange will be always availible if you have more than one, this is part of the patch.

Anonymous’s picture

Anonymous (not verified) commented

Sure, but if you only have one field, will it just be
- add

and no rearrange?

dawehner’s picture

dawehner
Primary language German
commented

It will be add and rearrange because you should be able to delete it without the need to go to a specific field.

That's at least for me logical.

Anonymous’s picture

Anonymous (not verified) commented

Just raising these points -

Regardless of how many fields there are:
"rearrange" indicates the ability to sort fields but it isn't obvious that the user will also be able to delete fields by clicking this option.

If there's only 1 field:
"rearrange" doesn't make sense as an action since you can't sort a single field...

That's why I was suggesting "edit" as a more generic action that doesn't suffer from these problems. I don't think there's a confusion between editing the group of fields (to rearrange and delete them) and clicking on a single field since there would be only one "edit" within that section. When you click on a single field, it's just a direct link anyway and the next page heading says "Configure Fields:xxxx".

dawehner’s picture

dawehner
Primary language German
commented

In general i would expect to edit the fields when i click edit. But you can't edit them, but just remove/sort around.

Anonymous’s picture

Anonymous (not verified) commented

The "edit" option would be hidden away in the dropbutton anyway (assuming javascript is enabled) so I don't think that's a problem. You're editing at the group level to reorder and delete rather than configuring individual fields.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.