Closed (fixed)
Project:
Ubercart MIGS Gateway
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Apr 2011 at 01:10 UTC
Updated:
16 Nov 2011 at 00:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
xurizaemonYes, there definitely will be a version as soon as I can commit time to making it happen.
Happy to accept patches or contributions in the meantime. You may contact me via my user profile if interested in sponsoring the work.
Comment #2
peterx commentedAny chance of Drupal 7 + Ubercart 3.0 + Commonwealth Bank?
Before 2:00 pm? :-)
No just kidding, 3:00 pm will be ok. :-)
Should UC 3 be a different issue? I do not know if UC 3 changes the way payment modules hook in.
Comment #3
peterx commentedOk, it is 2:12. Here is a patch that gets as far as the config screen. I do not have CBA test configuration to proceed.
Looks like a few Ubercart hooks renamed from hook_x to hook_uc_x. I changed one to get the payment details on the screen.
The patch is out of Winmerge using the unified 3 option.
Comment #4
peterx commentedThe patched code produces the following error everywhere.
Notice: Undefined index: render element in theme() (line 824 of /var/www/kbwebhub.ampco.com.au/public_html/includes/theme.inc).
I have the Credit card and Test gateway modules switched on. The checkout produces the following list. I do not know if the MIGS module can reuse anything from the Credit card module.
When I review order, I get the following message and a small array next to the Submit order button.
Comment #5
peterx commentedThe theme related error disappeared when I replaced 'arguments' with 'variables' in the theme function:
'uc_migs_order_incomplete' => array('variables' => array(Comment #6
peterx commentedPatch for previous post.
Comment #7
peterx commentedTry this new patch. It works in Drupal 7 and picks up the visa/mastercard images from the credit card module. The credit card image pickup could be an installation action instead of the inline function I used.
Comment #8
peterx commentedAnother change. This lists the cc images in admin. For some reason the patch generator replaces the whole of the module file. It lists only a few lines of differences but puts everything in the patch file.
Comment #9
xurizaemonI've opened branches for 7.x-1.x and 7.x-2.x.
Here's my patch for 6.x-2.x => 7.x-2.x
Comment #10
xurizaemonAnd some more ... this is in 7.x-2.x now also.
Comment #11
xurizaemonFurther updated. This single patch is 6.x-2.x..7.x-2.x. The previous two were cumulative, and the last one actually reverted a bunch of stuff. Sorry.
Comment #12
xurizaemonPayments were not getting recorded to the order. Call to
uc_payment_enter()fixed by nick_schuch, thanks.Comment #13
xurizaemonThanks peterx for the DB update report in #1324538: Smoke less also.
Marking this closed now; please create separate issues against 7.x-2.x for anything else discovered.
Comment #14
xurizaemonHaha that typo issue reference is gold. I meant #1324358: drupal_theme_rebuild() not #1324538: Smoke less :)