Hi just wondering if there is any chance of this being upgraded to D7? Many thanks.

Comments

xurizaemon’s picture

Title: D7? » Drupal 7 version of uc_migs
Category: feature » task
Status: Active » Needs work

Yes, there definitely will be a version as soon as I can commit time to making it happen.

Happy to accept patches or contributions in the meantime. You may contact me via my user profile if interested in sponsoring the work.

peterx’s picture

Any chance of Drupal 7 + Ubercart 3.0 + Commonwealth Bank?
Before 2:00 pm? :-)
No just kidding, 3:00 pm will be ok. :-)

Should UC 3 be a different issue? I do not know if UC 3 changes the way payment modules hook in.

peterx’s picture

StatusFileSize
new4.54 KB

Ok, it is 2:12. Here is a patch that gets as far as the config screen. I do not have CBA test configuration to proceed.

Looks like a few Ubercart hooks renamed from hook_x to hook_uc_x. I changed one to get the payment details on the screen.

The patch is out of Winmerge using the unified 3 option.

peterx’s picture

The patched code produces the following error everywhere.
Notice: Undefined index: render element in theme() (line 824 of /var/www/kbwebhub.ampco.com.au/public_html/includes/theme.inc).

I have the Credit card and Test gateway modules switched on. The checkout produces the following list. I do not know if the MIGS module can reuse anything from the Credit card module.

Select a payment method from the following options.
Subtotal:	$27.00
GST:	$2.70
Order total:	$29.70
Payment method *
Credit card:
Credit card on a secure server.

When I review order, I get the following message and a small array next to the Submit order button.

Warning: Parameter 1 to uc_migs_form() expected to be a reference, value given in drupal_retrieve_form() (line 773 of /var/www/kbwebhub.ampco.com.au/public_html/includes/form.inc).
peterx’s picture

The theme related error disappeared when I replaced 'arguments' with 'variables' in the theme function:
'uc_migs_order_incomplete' => array('variables' => array(

peterx’s picture

StatusFileSize
new4.69 KB

Patch for previous post.

peterx’s picture

StatusFileSize
new50.81 KB

Try this new patch. It works in Drupal 7 and picks up the visa/mastercard images from the credit card module. The credit card image pickup could be an installation action instead of the inline function I used.

peterx’s picture

StatusFileSize
new50.92 KB

Another change. This lists the cc images in admin. For some reason the patch generator replaces the whole of the module file. It lists only a few lines of differences but puts everything in the patch file.

xurizaemon’s picture

Status: Needs work » Needs review
StatusFileSize
new13 KB

I've opened branches for 7.x-1.x and 7.x-2.x.

Here's my patch for 6.x-2.x => 7.x-2.x

xurizaemon’s picture

Title: Drupal 7 version of uc_migs » Port uc_migs to Drupal 7
StatusFileSize
new13 KB

And some more ... this is in 7.x-2.x now also.

xurizaemon’s picture

Version: 6.x-1.x-dev » 7.x-2.x-dev
StatusFileSize
new18.83 KB

Further updated. This single patch is 6.x-2.x..7.x-2.x. The previous two were cumulative, and the last one actually reverted a bunch of stuff. Sorry.

xurizaemon’s picture

Payments were not getting recorded to the order. Call to uc_payment_enter() fixed by nick_schuch, thanks.

xurizaemon’s picture

Status: Needs review » Fixed

Thanks peterx for the DB update report in #1324538: Smoke less also.

Marking this closed now; please create separate issues against 7.x-2.x for anything else discovered.

xurizaemon’s picture

Haha that typo issue reference is gold. I meant #1324358: drupal_theme_rebuild() not #1324538: Smoke less :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.