It would be really cool to have some nice control images by default. The ones made by MapBox and Dev Seed are awesome. We can easily make this a default value.

So, the questions, specifically for @tmcw and Dev Seed, are the following:

* What is the license on these files?
* It is alright if we use these?
* It is alright if we include them in the module?

CommentFileSizeAuthor
#26 ol - missing pieces.tar_.gz84.6 KBndagire
#25 ol - missing pieces.tar_.gz77.94 KBndagire
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phayes’s picture

phayes CreditAttribution: phayes commented

I would also see if we can integrate openlayers_plus by default

tmcw’s picture

tmcw CreditAttribution: tmcw commented

Unsure about this - the images are BSD licensed.

And, openlayers_plus, as well as being BSD licensed, is a very large chunk of non-OL-native code - something that we've been trying to avoid here.

phayes’s picture

phayes CreditAttribution: phayes commented

Would dev-seed be willing to dual-license these as BSD / GPLv2?

mailking’s picture

mailking CreditAttribution: mailking commented

That would be interesting. If not, is there a simple way to custom [make your own] controls?
Adventurous greetings,
Coen

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Hi @mailking. The basics are just creating new images with the same name that OpenLayers expects them, then put them in a directory, and point to them when making a map. Requires icon making skills.

@tmcw, would DevSeed be offended if we hosted them somewhere else, added the rest of the icons, and pointed to them by default. Since we are already using OpenLayers external resources, this would not be any sort of performance issue (as long as where it is hosted is stable).

mailking’s picture

mailking CreditAttribution: mailking commented

I really like what DevSeed did with the preparedness maps and interaction. I would really like to build such a map and interface for our worldly wanderings. Kudo's. Would I be able to replicate it in D7?
Adventurous greetings,
Coen

tmcw’s picture

tmcw CreditAttribution: tmcw commented

@zzolo: I've added a GPLv2 to the openlayers_themes repo, so consider it dual-licensed. Feel free to fork, or host or whatnot. Though... the OpenLayers 'hosted Javascript' scenario has always been a pile of failure, and I think the only valid reason for having the module use the hosted version is the BSD-licensing of the project.

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Many thanks, @tmcw.

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Here's the thing that may have been overlooked. Though the mapbox/devseed images are awesome, they are not a complete set of images that OpenLayers would assume are there. But those images are BSD.

So, ideally we would make a full set of images to include in the module (probably based off the Mapbox designs). Otherwise, we can't really put the images in this repository.

The other option is to combine the two sets, and have someone host them for us. Not a huge fan of this one.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented

+1 for this, and for zzolo's first option:

ideally we would make a full set of images to include in the module (probably based off the Mapbox designs).

What are we missing?:
$ diff openlayers_themes/dark OpenLayers-2.10/img/ | grep -v Binary

Only in OpenLayers-2.10/img/: cloud-popup-relative.png
Only in OpenLayers-2.10/img/: drag-rectangle-off.png
Only in OpenLayers-2.10/img/: drag-rectangle-on.png
Only in OpenLayers-2.10/img/: marker-blue.png
Only in OpenLayers-2.10/img/: marker-gold.png
Only in OpenLayers-2.10/img/: marker-green.png
Only in OpenLayers-2.10/img/: marker.png
Only in OpenLayers-2.10/img/: measuring-stick-off.png
Only in OpenLayers-2.10/img/: measuring-stick-on.png
Only in OpenLayers-2.10/img/: panning-hand-off.png
Only in OpenLayers-2.10/img/: panning-hand-on.png
Only in openlayers_themes/dark: zoom-panel.png

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Hi @jeffschuler. The thing is that those images are BSD licensed so we can't include those in this module by default. The big one is the cloud popup image as this will make all the popups look real bad.

phayes’s picture

phayes CreditAttribution: phayes commented

@zzolo, I believe as per tmcw's #7 these are now dual licensed GPLv2 and BSD, so we can include them.

zzolo’s picture

zzolo CreditAttribution: zzolo commented

:) Right, but the issue is that the MapBox icons are now GPL which is awesome, but we still dont' have a complete default icon set that the OL library expects that is GPL, specifically the popup is the biggest missing piece.

phayes’s picture

phayes CreditAttribution: phayes commented

Ah, I see. Any pop-up artists out there????

zzolo’s picture

zzolo CreditAttribution: zzolo commented

So, as I am trying to get some designers/artists to help out, I am going to spell this issue out a bit more.

Goal

We want to provide a nice set of images (and possibly CSS) for the OpenLayers interface to use. (We usually call this an OpenLayers theme)

Background

OpenLayers, the library, uses a default set of images to pull in icons for interface controls. These are named specific files. By default, the library pulls them from the hosted directory of images. This can be overridden by using the ImagePath setting, which will set a new directory for OpenLayers to use, which contains images of the same name.

MapBox Theme

MapBox (ie Development Seed) put together a great set of icons to use. Mapbox provides a limited set of icons for OpenLayers that they have been really nice to license as GPL as well.

The Problem

The default OpenLayers images are licensed under BSD and cannot be offered as part of this module (and are ugly). And, the MapBox set is incomplete.

The Solution

So, we need to create a full set of images. Given that there is already work done, and source available, for some nice looking icons from MapBox, it would make sense to just fill in the missing icons using the same design. But if someone wants to start a new design, that would be cool too.

Bonus

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented

+1 subscribe, and marking this for myself, as I may be able to help contribute designs for this. The lack of the popup image was killing me until I realized what was going on. We definitely don't want to enable something with missing images by default.

kae76’s picture

kae76 CreditAttribution: kae76 commented

o/

I'm up to help out :) Thanks @zzolo

ndagire’s picture

ndagire CreditAttribution: ndagire commented

I had started up on something similar. Will definitely go through the missing images, would be nice for me too.

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Thanks everyone for wanting to help out! It would also be great if there was coordination, so if people have created an image, just posting it here would be fine, and we can start to create the whole set.

kika’s picture

kika CreditAttribution: kika commented

subscribing

ao2’s picture

ao2 CreditAttribution: ao2 commented

I too am interested in a better default style.

Listing explicitly the missing images and stylesheets can help people decide what they can/want to help on.

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
CreditAttribution: dasjo commented
Component: OpenLayers UI » OL API

coming here in order to change openlayers controls to the maki set

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
CreditAttribution: dasjo commented
Component: OL API » OL UI

accidentally changed the component.

using https://github.com/pigletto/openlayers_themes/tree/master/dark works for me so far

see also #928268: Add cloud-popup-relative.png to Dark theme

ndagire’s picture

ndagire CreditAttribution: ndagire commented
FileSize
ol - missing pieces.tar_.gz77.94 KB

Hi everybody, I spent some time on the missing icons, open layers - in ref. to MapBox.
Let me know what you think.

ndagire’s picture

ndagire CreditAttribution: ndagire commented
FileSize
ol - missing pieces.tar_.gz84.6 KB

I had missed a few. Ok, this is it

steinmb’s picture

steinmb CreditAttribution: steinmb commented

Great work :-D
I have not taken them for a spin in OL yet, but wanted to let you know that what I thought. I really like mono-icons.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented

Hey, nice work ndagire! These are looking good.

I wonder about using the "+" symbol in markers. These would make me think I can add something by clicking the icon...

Also noticed that some items have a different shade of dark background than others. I haven't seen this in the context of a map yet. Was this intentional?

ndagire’s picture

ndagire CreditAttribution: ndagire commented

Hey, thanks guys.

Jeff, about the + plus, I thought about it. The marker is sort of a place holder, before define a place. Hence the +.
But yeah, with feedback coming in, we can always revise the set.
In the open layers set, there some icons that are slightly bigger than those from the editing tool bar. Still to get a screen dump as they appear on the map.

Steinmb, mono-icons are great, had done a few on a recent project, so I thought these could be a little different in reference to the icon set from Map Box.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented

ndagire: I'm not sure what you mean by "The marker is sort of a place holder, before define a place." I think these are general-purpose markers and shouldn't really indicate any other meaning.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented

There's probably a much easier way to demo/test all of these new icons, but I crawled http://openlayers.org/dev/examples/, re-set those pages up on my own server, and replaced the images with the ndagire's additions (plus the Mapbox set.)

See: http://openlayers-images.websubstrate.com/examples/

I had to do some fiddling, but most examples work. Most, though, don't actually show many of the icons. A few that make use of the new icons are:

zzolo’s picture

zzolo CreditAttribution: zzolo commented

@ndagire, great work! These are awesome. Hopefully I will have some time soon to put these into the module as the default.

ndagire’s picture

ndagire CreditAttribution: ndagire commented

I would like to refer to the, resizing marker issue.
If the new marker is not working on this, it's because it has a fixed width and height like the previous open layers icon.

Alternatively, we could have an image replacement on different zoom levels. I don't know hw this could work.

Or, have one marker icon which can be resized from different levels. Low zoom level to high, small to big. May be using image pre-sets or any other developer tools you might like to use.

ao2’s picture

ao2 CreditAttribution: ao2 commented

Thanks @ndagire, what about the shade of the background?
jeffschuler in #28 noted that it is a bit different from the mapbox ones (maybe a different opacity value?)

Also, what about adding a dark version of the tooltip bubble?

Finally, a .svg with the old AND the new icons would be great to have :)

Thanks,
Antonio

zzolo’s picture

zzolo CreditAttribution: zzolo commented
Status: Active » Fixed

Done! I added the images, and set them as the default for maps, as well as updated some style for the layer switcher. It will not affect already existing maps (and had to add some logic for that). Please test out.

Thank you for all your hard work on this. Please feel free to re-open to add new images.

http://drupalcode.org/project/openlayers.git/commit/a9a33b4

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.