Opening this here as a related to: http://drupal.org/node/76379 since the actual implementation of signatures in profile.module is a different issue.

Profile already does everything needed to produce signatures, so I'm not sure where to start to be honest. Quickly I guess the following would need to be done:

1. signature to be set up as a default field in profile.module - might this be the installer rather than the module itself??

2. an upgrade path to move signatures from the user table to a profile field

3. Something somewhere to actually display the signatures in comments...

Comments

webchick’s picture

Title:Take over signatures from comment.module» Move signatures to profile.module

This is an interesting proposal. In my 5,000 patches designed to fix signatures in one way or another, I hadn't thought to put them in with profile.module. ;) Kind of makes sense, and then the feature is disable-able as well, which is a feature some people asked for.

Implementation-wise, there is a profile_install() function in profile.install... here is where you could pre-populate the Profile fields with a "Signature" field if you wanted.

However, there are a number of issues. For example, how to display the signature automatically in nodes and/or comments without requiring people to hack their themes? We could add a new variable in phptemplate to output $signature and add it to node/comment.tpl.php files by default. But then it's kind of weird to do this only with signatures and not with other profile fields. Should we make all profile fields "togglable" in this way? How to migrate old sites that are using signatures but not profile module? etc.

Needs some more thinking I think. Hopefully that gets the ball rolling though.

catch’s picture

I'll be honest here and say the only reason I'm proposing this is my pathological dislike of signatures. I just want to be able to switch them off ;) However we do use location and tagline fields from profile.module in our comment.tpl.php instead which is pretty similar.

We could add a new variable in phptemplate to output $signature and add it to node/comment.tpl.php files by default. But then it's kind of weird to do this only with signatures and not with other profile fields. Should we make all profile fields "togglable" in this way?

This would makes sense to me, and fit with our own use-case - a default (but deletable?) field for signatures, then the option to toggle further custom fields in comment (and node?) displays.

How to migrate old sites that are using signatures but not profile module? etc.

Presumably unless they've deleted the profile table from the db then any migration would just require enabling profile.module when they upgrade?

The issue with this is the extra weight from profile.module I guess (minus the weight taken out of comment.module). Less weight than providing an additional contrib signature.module on top of the core profile.module though.

There's also the problem of duplicate signature display on old sites which it seems was partially dealt with on the other issue.

On that note, it just occurred to me that user images could potentially be moved to profile in the same way...

catch’s picture

no images in profile module though so I'll leave that one for now.

Pasqualle’s picture

Version:6.x-dev» 7.x-dev
Damien Tournoud’s picture

Status:Active» Closed (won't fix)

Having signature management in Comment makes a lot of sense. After all, they are mostly used in comments... Because there have been a lot of work since then (notably #132446: User signatures for nodes), I'm won't fixing this.