Thank you for this module set. I read the README file from start to finish and tried to search for any similar issues but with no luck. I really want it to work on my website but I've realised there's an issue with javascript_aggregator and I couldn't solved this problem so I decided to ask an advice. I have javascript_aggregator on my website to minify javascript files used there and it worked flawlessly until I enabled fb module and fixed my config file in accordance to README. Now javascript is broken. At the top of the page "NOT IMPLEMENTED: DEBUGGER" message occurs as my Suckerfish menu (provided by simply_modern theme) becomes really tall on every "first" page load (those effects disappear after reloading the page). Some of my modules are crying "Please enable javascript" including OpenID_selector and Mail_ru my users like so much. It's quite interesting both of those modules work great with either fb or javascript_aggregator enabled but don't work when I tried to enable fb AND js_agg. I tried different combinations, cleared all cache (lots of times), enabled and disabled other modules and enabled troublesome modules in different orders but nothing has changed. Unfortunately I cannot just disable js_agg because of the site performance so now it's a necessity for me to find a working solution where both modules can be enabled.

Comments

Dave Cohen’s picture

Dave Cohen commented

I checked in a call to debugger; in fb.js because I'm not sure how to handle ajax errors there. So either that ajax error handler is being reached, or it is somehow choking on debugger; even before it is called.

Try commenting out that line to see if that makes a difference.

Ingumsky’s picture

Ingumsky commented

Thank you Dave! I'll try.

As I can see in Google Chrome Console (and in Firebug too) there're two similar errors related to sets of inline fb-related js code:
Uncaught ReferenceError: jQuery is not defined.
The first one is:
jQuery.extend(Drupal.settings, { "basePath": "/", "fb_connect": { "front_url": "/", "fbu": null, "uid": 0 } ...
The second one is:
jQuery.extend(Drupal.settings, {"fb":{"ajax_event_url":"http:\/\/example.net\/fb\/ajax","fb_init_settings":{"xfbml":false, ...
Hope it helps.

I can share with you a link to my test domain where those errors occur so you can check console errors right there.

Dave Cohen’s picture

Dave Cohen commented
Project: Drupal for Facebook » Javascript Aggregator
Version: 6.x-3.0-rc11 » 6.x-1.x-dev

I don't understand what could cause it, but if jQuery is not defined, that's a big problem. I suspect it's a problem with javascript aggregator.

bartezz’s picture

bartezz commented

Getting similar issues as in #2, not using fb though.
Will try to find out and post back...

Cheers

bartezz’s picture

bartezz commented

Turns out it was colorbox module. When disabled all works fine.
When enabled I'm getting 'jQuery is not defined' if I turn on javascript aggregation...

jQuery.extend(Drupal.settings, { "basePath": "/", "colorbox": { "transition": "elastic", "speed": 350, "opacity": "0.85", "slideshow": false, "slideshowAuto": false, "slideshowSpeed": 2500, "slideshowStart": "", "slideshowStop": "", "current": "{current} of {total}", "previous": "« Prev", "next": "Next »", "close": "Close", "overlayClose": true, "maxWidth": "100%", "maxHeight": "100%" }, "fivestar": { "titleUser": "Your rating: ", "titleAverage": "Average: ", "feedbackSavingVote": "Saving your vote...", "feedbackVoteSaved": "Your vote has been saved.", "feedbackDeletingVote": "Deleting your vote...", "feedbackVoteDeleted": "Your vote has been deleted." }, "googleanalytics": { "trackOutgoing": 1, "trackMailto": 1, "trackDownload": 1, "trackDownloadExtensions": "7z|aac|arc|arj|asf|asx|avi|bin|csv|doc|exe|flv|gif|gz|gzip|hqx|jar|jpe?g|js|mp(2|3|4|e?g)|mov(ie)?|msi|msp|pdf|phps|png|ppt|qtm?|ra(m|r)?|sea|sit|tar|tgz|torrent|txt|wav|wma|wmv|wpd|xls|xml|z|zip" }, "spamspan": { "m": "spamspan", "u": "u", "d": "d", "h": "h", "t": "t" } });

// error: Uncaught reference error: jQuery is not defined

Don't have a clue as to how to fix this so disabling javascript aggregator for now...

Cheers

el_reverend’s picture

el_reverend commented

This might be an issue with the JSMin+ option only. I am currently trying this module without this option and at least so far I am not getting this error message.

mahsandu’s picture

mahsandu commented
Status: Active » Fixed

I also troubled with same error.

But when disabled JSmin+ it works fine .

So it is the error of JSmin+ .

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.