Submit buttons in the content type settings lack #weight [#111537]

I want to insert a fieldset in the content type settings a.k.a. node_type_form.

node_type_form() in content_types.inc defines three submit buttons, and none of them has its weight specified. This is especially annoying as the buttons are not inside a single 'buttons' group, so even if my hook_form_alter() implementation moves all three of the buttons I still have to assume that any buttons from some other hooks don't play nice with my fieldset.

The standard add/edit node form assigns 40, 45 and 50 as weight for its submit buttons, which seems sensible to me. Therefore, the attached patch does the same with the buttons from node_type_form.

Comment	File	Size	Author
	node_add_type_settings_weight.diff	647 bytes	jpetso

Comments

Comment #1

jpetso commented 29 January 2007 at 12:38

Status:

Active

» Needs review

Oh right, this has got a patch attached, thus change the bug's status. Please review for inclusion.

Comment #2

jpetso commented 3 February 2007 at 15:14

Version:	5.0	» 5.x-dev
Status:	Needs review	» Reviewed & tested by the community

kkaefer told me to file this issue against 5.x-dev and mark it as ready to be committed. (The patch still applies on CVS HEAD.)
I really hope someone cares to take five minutes to look at this and comment or commit (or dismiss, but _some_ feedback would be great) - I'd love to see it in Drupal 5.2.