The views_export module has missing labels on the export form. This makes it difficult to know what to call the files to create the export module.

The form $element_info array has the #title set for theming, but the title doesn't show up. The textarea theming occurs on lines 269 -274 of the views_export.module.

It seems that using …

$form_state['output'] = theme('textarea', array(
    'element' => $element_info));

doesn't use the theme_textarea() function in form.inc

Apologies if this is a core bug, other forms generate labels, so I assume it specific to views_export. It happens with the overlay themed as Rubik & Seven, I can't see a label in the source either.

CommentFileSizeAuthor
#13 Removing-export-help-1114772-13.patch3.67 KBdrew reece
#13 Adding-help-for-Views-exports-1114772-13.patch6.85 KBdrew reece
#12 Adding-help-for-Views-exports-1114772-12.patch6.86 KBdrew reece
#12 Removing-export-help-1114772-12.patch3.69 KBdrew reece
#6 ctools-export-help_4-4-2011.zip3.03 KBdrew reece

Comments

dawehner’s picture

dawehner
Primary language German
commented

I would suggest to drop the views_export module and use the ctools variant.

drew reece’s picture

drew reece commented

Thank you dereine,

For anyone else as foolish as me, activate the Chaos tools 'bulk exporter' module & uninstall the 'Views exporter' (in the views section).
I guess this issue should be changed to a request to remove the views_export module?

dawehner’s picture

dawehner
Primary language German
commented
Title: Views export has missing labels in export form » Remove views bulk export module and point to ctools bulk export
Category: bug » task

Yes. Updated title etc.

Any opinions from other people? earl?

bojanz’s picture

bojanz commented

Makes sense.

merlinofchaos’s picture

merlinofchaos commented

I agree. Views bulk export module is no longer needed or valuable; I've already verified that CTools bulk export module can export Views. We need to remove the module and update the documentation.

drew reece’s picture

drew reece commented
StatusFileSize
new ctools-export-help_4-4-2011.zip3.03 KB

Here is a modified version of the help files for exporting views.
I started with the 'example-bulk-export.html' from views/help and updated it with the additional Chaos tools requirements.

I have also made a help file for 'single views exports'.

Does this need turning into a patch & do I need to post this in the Ctools issue queue?
Hope it helps.

dawehner’s picture

dawehner
Primary language German
commented
Assigned: Unassigned » esmerel

Great to work on the help files! The changes seems to be fine, but assign this to esmerel

merlinofchaos’s picture

merlinofchaos commented

A patch is FAR preferable to a zip. There's no way to easily tell what changed to review the changes.

merlinofchaos’s picture

merlinofchaos commented

I just removed the module itself.

drew reece’s picture

drew reece commented

Sorry merlinofchaos,
I'm not sure how to patch across 2 modules (& have it work on D.O), the help files came from views/help and now they live in ctools/help. I'm assuming it would just be a patch for the creation of the help files in ctools?

merlinofchaos’s picture

merlinofchaos commented

Yeah, it'd be two separate patches.

drew reece’s picture

drew reece commented
StatusFileSize
new Removing-export-help-1114772-12.patch3.69 KB
new Adding-help-for-Views-exports-1114772-12.patch6.86 KB

Here are patches for removing & adding the help files. I added to the ctools.help.ini to make them show up in the index.
I think the 'exportable section' in the ctools help index (admin/advanced_help/ctools) could be grouped in the index, but it is unclear to me how it should be arranged.

Maybe something like…
Exportables

  • Export and importing a view
  • Export views to a module
  • Exportable objects UI creator
  • Exportable objects tool

I'm not sure what 'Exportables' title should link to.

drew reece’s picture

drew reece commented
StatusFileSize
new Adding-help-for-Views-exports-1114772-13.patch6.85 KB
new Removing-export-help-1114772-13.patch3.67 KB

The same patch without my name in the commit message, sorry for that.

merlinofchaos’s picture

merlinofchaos commented
Project: Views (for Drupal 7) » Chaos Tool Suite (ctools)
Version: 7.x-3.x-dev » 7.x-1.x-dev
Status: Active » Needs review

Committed the Views half of this. Moving to CTools.

merlinofchaos’s picture

merlinofchaos commented
Project: Chaos Tool Suite (ctools) » Views (for Drupal 7)
Version: 7.x-1.x-dev » 7.x-3.x-dev

On the CTools side, I don't think I'm satisfied with this. It references Views' specifically and on the CTools side it should be more generic. Which means we may need to actually reverse some of this, and restore some of the Views' export documentation.

drew reece’s picture

drew reece commented

I'm not sure I can untangle the changes in terms of ctools & views separation.

There is a case when only one module will be installed, but that would have to be ctools, since views requires ctools.
Having this help is useful when views isn't already installed, because it partly covers install & setup instructions.
Would it make sense for views to provide help on a module that it doesn't contain inside it's own project?

I think that the help is focusing on using the bulk export module, within ctools, and fits into ctools. I really don't mind if it goes into either module, but I think it is a reasonable place to start. Work it into whatever plans you have for these great modules merlinofchaos :)

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

Perhaps you don't understand.

In CTools:

+[export-views-single]
+title = Export and importing a view
+
+[export-views-bulk]
+title = Export views to a module

Why would this reference Views at all? That's *any* exportable thing. So that simply can't go into CTools because it's telling you how to export Views. There is no way that will make sense to a user.

The Views side probably just needs a little document that points to the CTools document (which is guaranteed to be there and easy to write) and the CTools document needs to be scrubbed of references to Views.

drew reece’s picture

drew reece commented

Why would this reference Views at all? That's *any* exportable thing. So that simply can't go into CTools because it's telling you how to export Views. There is no way that will make sense to a user.

I'm still confused. What do you mean by it being *any* exportable thing? Where would you like me to stick it ?!

I realise the help is views specific, but the views_export module was removed, so ctools is responsible for the views exporting feature.
I'd love to help resolve this, but I can't understand wth the solution should be.

My use case is to dump a views settings to a file to migrate else where, are we thinking on the same lines?

merlinofchaos’s picture

merlinofchaos commented

Okay, I'm not sure why this doesn't make sense to you:

CTools does not document Views.

Views are not the only things exported by the bulk export module.

drew reece’s picture

drew reece commented

Right, I haven't used bulk export for any other purpose AFAIK, I thought it's job was replacing the removed views_export.
Maybe there should be help for the other forms that bulk export can handle, at least the ones that require involved processes to use.

Does it seem more appropriate to stick the help into views or the views_exporter module?
Let me know if I need to do anything, I clearly have little grasp on this… just trying to help.

drew reece’s picture

drew reece commented

It looks like it is already explained in the 7.x-3.0-beta3 branch (commit 70c406077ff1ef27bf) of views. I guess it should be removed entirely from ctools.

xjm’s picture

xjm
she/her
Primary language English
commented

So, funny side effect of removing the module but leaving the empty .module file. Installing core 8.x shows this message when views is already present in sites/all/modules:

Warning: filemtime() [function.filemtime]: stat failed for sites/all/modules/views/views_export/views_export.info in _system_rebuild_module_data() (line 2680 of core/modules/system/system.module).

We can probably remove the dummy module in the 8.x branch at least?

Edit: I apparently actually had 7.x-3.x checked out, so this is irrelevant for D8.

summit’s picture

summit commented
Issue summary: View changes

Hi,
For D7 I was not sure how to automatically export and import a bulk of views. I had to do it manually...
may be I missed something, but the automatic export I couldn;t find..
greetings, Martijn

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Fixed

Nothing left to do here.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.