Don't specify ErrorDocument when mod_rewrite is enabled [#1114736]

We currently specify "ErrorDocument 404 /index.php" in .htaccess. But this is not relevant when mod_rewrite is enabled, because then we pass all requests on to index.php.

This patch moves the ErrorDocument definition into an IfModule !mod_rewrite block to make it clearer to the reader of the code that the definition is not relevent in those >95% of the cases where mod_rewite is installed.

Comment	File	Size	Author
	error-document-1.patch	912 bytes	c960657

Comments

Comment #1

damien tournoud commented 3 April 2011 at 15:40

Priority:	Minor	» Major
Status:	Needs review	» Needs work

Ok, I understand what happens now :)

We had this ErrorDocument *all along*, but it was of absolutely no use to anybody *until* we made Drupal read its current path from the URL instead of $_GET['q'] (in #284899: Drupal url problem with clean urls).

This makes clean-URLs sort-of-work without mod_rewrite, but only sort of: only GET/HEAD requests are properly passed through (example: #932636: Drupal *always* installs with clean URLs). We just need to completely remove this useless ErrorDocument from .htaccess and everyone will be happy.

Comment #2

damien tournoud commented 3 April 2011 at 15:40

Category:

task

» bug

And promoting to a bug.

Comment #3

quicksketch

he/him

commented 1 June 2011 at 03:50

Priority:

Major

» Normal

Per #1050616: Figure out backport workflow from Drupal 8 to Drupal 7, it looks like major and critical bugs will actually start preventing any new development of Drupal core. This is hardly a major bug, considering it has hardly any effect on the normal functionality of Drupal.

Personally I'd like to see the ErrorDocument line removed entirely. I usually remove it for performance reasons.

Comment #4

1 June 2011 at 03:50

Version:

8.0.x-dev

» 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #5

1 June 2011 at 03:50

Version:

8.1.x-dev

» 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.