I think we can restore them in the drop-down for the display, easily enough. Maybe just a "Go to path". We have to make sure that the path is valid (i.e, no % in the path) and that the display has is not 'new'.

CommentFileSizeAuthor
#7 views-1113732-7.patch2.21 KBtim.plunkett
#4 views-1113732-4.patch847 bytestim.plunkett
#4 views-1113732-4-MOVED.patch1.84 KBtim.plunkett
#1 1113732-links-to-path.patch1.3 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1113732-links-to-path.patch1.3 KB

Here is a patch for this issue.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Tested this patch a bit and commited it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new views-1113732-4-MOVED.patch1.84 KB
new views-1113732-4.patch847 bytes

I'd normally open a new issue, but this is so specific I really thought it belonged here. Please chastise me if I was wrong.

I was snooping around for the "View" link, and finally found it buried beneath "Clone". That's fine, but there were some discrepancies in the title and the class. Attached is a patch to fix that.

But in thinking about this more, I really think "View" should be much higher up on the list. In addition, I don't think you should be able to "View" a disabled view. That is the second patch. (Which incorporates the fix from the first patch.)

merlinofchaos’s picture

merlinofchaos commented

How far up does this move it? I think 'view' is a nicer default that 'clone' so I'd happily agree to move it all the way to the top.

I also agree about not being able to view disabled displays.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

This puts it all the way at the top:

Enable
View
Clone
Delete
Disable
Undo Delete

With those being displayed according to their own conditions.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new views-1113732-7.patch2.21 KB

Okay, rerolling #4, going with the patch that moves it to the top per #5.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

It's much better there. Commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.