In general it would make sense to choose a proper default value for the translation plugin setting.

For example if there is just one language on your site there is no point in using the core translation method.
When you have installed i18nviews you almost 100% want to use this plugin.

CommentFileSizeAuthor
#4 1112500-locale-default.patch1.83 KBdawehner
#2 1112500-locale-default.patch1.55 KBdawehner

Comments

merlinofchaos’s picture

merlinofchaos commented

Obviously, i18nviews should just change the setting as part of its hook_enable() (and unset it as part of its hook_disable()) -- we can file that as an issue to i18nviews.

Is there anything Views itself should do with this setting outside of i18nviews?

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1112500-locale-default.patch1.55 KB

Here is a patch for it. Not sure whether this should be perhaps better be handled on installation instead of runtime.

merlinofchaos’s picture

merlinofchaos commented

It would be best to encapsulate teh variable_get() so instead we have:

views_get_localization_plugin() or something that gets the proper plugin default, I think. It'll reduce code just slightly.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 1112500-locale-default.patch1.83 KB

Here is a rerole for it

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Reviewed & tested by the community

Looks good. Needs 6.x-3.x as well.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Got commited already

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Regression due to this commit: #1226068: Views no longer export with $translatables by default