Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
similar issue #1107384: wrong instance definition in node.module
Comment | File | Size | Author |
---|---|---|---|
#8 | 1111288-fix-D8.patch | 3.8 KB | yched |
#6 | 1111288-fix-D7.patch | 109 bytes | yched |
#6 | 1111288-fix-D8.patch | 3.7 KB | yched |
#3 | field_ui_test_2.patch | 715 bytes | droplet |
field_ui_test.patch | 1.67 KB | droplet | |
Comments
Comment #2
yched CreditAttribution: yched commentedThe 3rd hunk is correct, but for the other two, the current code is correct - this is about building form values for the 'add new field' line in Field UI's 'manage fields' form. In this form, the input for the widget is actually called 'widget_type'.
Comment #3
droplet CreditAttribution: droplet commentedahh. I see what happen. :)
Comment #4
yched CreditAttribution: yched commentedthanks !
Comment #5
Dries CreditAttribution: Dries commentedCommitted to 7.x and 8.x. Thanks.
Comment #6
yched CreditAttribution: yched commentedDries, the D8 commit also reverted #1097100: Remove all 7xxx update functions and tests (D6 to D7 upgrade path) for the following files :
modules/field/field.install
modules/field/modules/field_sql_storage/field_sql_storage.install
modules/node/node.install
See http://drupalcode.org/project/drupal.git/commitdiff/aeb0651fb650ad284c20...
Also, patch #3 changed the field_ui.test file from 644 to 755 (affects both D7 and D8)
Attached patches fix back D7 and D8.
Comment #7
yched CreditAttribution: yched commentedshould be RTBC.
Comment #8
yched CreditAttribution: yched commentedActually, it seems forum.install D8 has also been moved to 755 in a recent commit.
New patch for D8. Patch #6 is still valid for D7.
Comment #9
Dries CreditAttribution: Dries commentedAh, thanks. Committed to 8.x.
Comment #10
droplet CreditAttribution: droplet commentedsorry. seems them are my patches.
I set it prevent it happen again
Comment #11
Dries CreditAttribution: Dries commentedI don't understand #10. Did you mean to mark this RTBC again?
Comment #12
droplet CreditAttribution: droplet commented@11, my status changes is wrong (when I replied this comment I do not see your #9 reply)
Comment #13
yched CreditAttribution: yched commented@Dries : D7 needs to be fixed too :-) (field_ui.test 755 --> 644). Patch is in #6.
Comment #14
webchickWow, bizarre. I had no idea you could do chmod changes in patch form.
However, I tried to apply this and get:
So is #6 still necessary?
Comment #15
webchickWell it helps when I'm on the right branch, doesn't it? (EEEK!) Heh.
Committed to 7.x. :)
Comment #16
webchick.