e-Library Search Module [#1110950]

This Drupal 6 module (7 will be coming once I get a 7 install up to develop against) provides libraries with the ability to create configurable blocks containing a search form for searching their online card catalog.

The project link is:
http://drupal.org/sandbox/cap60552/1105612

You will need to point it to a valid SirsiDynix eLibrary card catalog to fully test it.

My institutions values follow.

Base URL to cgisirsi:
http://library.waubonsee.edu/uhtbin/cgisirsi
Library Policy:
TODD

Comments

Comment #1

cap60552 CreditAttribution: cap60552 commented 30 March 2011 at 18:18

Status:

Active

» Needs review

Comment #2

cap60552 CreditAttribution: cap60552 commented 1 April 2011 at 02:48

I now also have a version 7 module in the works. It functions, and passes the coder module.

Comment #3

janusman CreditAttribution: janusman commented 14 April 2011 at 19:57

Status:

Needs review

» Reviewed & tested by the community

I decided I'd do a quick review, outlining the points from http://drupal.org/node/894256:

Ensure that there is a detailed description of what the module does and a full description of how it differs from any other project

The description is a bit scarce; you might spend more time describing who the module is for, what problem it solves, how it looks, what users can do after it's installed, known issues, etc... instead of handing out the install instructions =)

Search through the files uploaded for any possible non-GPL, or third-party library files. Ask the applicant to explain these and make sure to point to relevant documentation.

There seems to be no problem here =)

Review for security.

No problems.

Review for best practices.

No problems

Review for coding standards.

Some minor issues:

Inconsistent indentation
Spacing (e.g. inconsistent spacing in if() => if (), etc)
Using linefeeds + newlines instead of just newlines

So, in all, it's ok by me =)

Comment #4

cap60552 CreditAttribution: cap60552 commented 15 April 2011 at 03:42

janusman I cleaned up the spacing issues and the indentation problems (I hope I got them all). I also switched the line endings, I was under the impression the git was supposed to fix those automatically.

I will work on more documentation and a better description. I am also planning on implementing the hooks needed for the advanced help module, once I read up on it.

Thank you for looking things over, and for your input.