When calling: views_include_default_views(TRUE), TRUE ($reset) is not passed into views_get_module_apis()

See backtrace for details:

-> views_include_default_views($reset = TRUE) views/tests/views_exposed_form.test:19
  -> views_include_handlers($reset = TRUE) views/views.module:751
    -> views_include($file = 'base') views/views.module:730
     => $used['base'] = TRUE views/views.module:653
    -> views_include($file = 'handlers') views/views.module:731
     => $used['handlers'] = TRUE views/views.module:653
    -> views_include($file = 'cache') views/views.module:732
     => $used['cache'] = TRUE views/views.module:653
    -> views_include($file = 'plugins') views/views.module:733
     => $used['plugins'] = TRUE views/views.module:653
    -> _views_include_handlers() views/views.module:734
      -> views_module_include($file = 'views.inc', $reset = ???) views/includes/cache.inc:13
        -> views_get_module_apis($reset = FALSE) views/views.module:660
CommentFileSizeAuthor
#1 views-1107912.patch767 byteskenorb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kenorb’s picture

kenorb CreditAttribution: kenorb commented
Status: Active » Needs review
FileSize
views-1107912.patch767 bytes

See attached patch.

It's depended by: #1101332: Call to a member function set_display() on a non-object in tests/views_exposed_form.test on line 34

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

Looks fine.

Commited to 6.x-3.x, but needs porting to 7.x-3.x

kenorb’s picture

kenorb CreditAttribution: kenorb commented

And the function in patch should have as well default value:

function _views_include_handlers($reset = FALSE) {

instead of:

function _views_include_handlers($reset) {

Because by default is called without arguments. Sorry for confusion.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Patch (to be ported) » Active

Can you please create a patch ?

MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented
Issue summary: View changes
Status: Active » Closed (won't fix)
kenorb’s picture

kenorb CreditAttribution: kenorb commented
Status: Closed (won't fix) » Fixed

Fixed in 6.x as per #2, there is no fix needed for 7.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.