There are two problems:
1) When adminsitering views, the main operations contain 'clone, export, enable, disable'. However, when editing a display, there are some operations (clone, export) but enabled/disabled status is a checkbox that you open up. It would be better if this were operations. i.e, you'd see 'clone, export, disable' or 'clone, export, enable'.
2) Disabled views aren't clearly marked. Especially if the advanced fieldset is closed, it's *really* difficult to tell if the display is disabled, and that will likely cause confusion.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1107482-enable_disable_dropdown.patch | 7.93 KB | dawehner |
| #3 | 1107482-enable_display-ui.patch | 7.63 KB | dawehner |
| #1 | 1107482-enable_disable-ui.patch | 4.94 KB | dawehner |
Comments
Comment #1
dawehnerHere is a initial work.
Don't even think to commit this because
a) there is no visual change whether a display is enabled/disabled
b) the click on the link does not work as expected at the moment.
Comment #2
merlinofchaos commentedDisabled displays can be indicated in two ways:
1) Add a class to the display tab. This class will change the fore and background color of the tab to be lighter than the nearby tabs.
2) Add text to the top of the disabled display to indicate that the display is disabled, probably after the display name.
3) Disabled displays should have 'enable' as the default display dropdown link.
Comment #3
dawehnerThis basically should work, but
if you disable a page display it automatically disables the value on the master display which isn't that good, because every new dispaly get's disabled too.
I'm wondering wether this setting makes sense as defautlable action.
Added some css to change opacity on disabled state.
Comment #4
merlinofchaos commentedNo, disabling absolutely shoud not be defaultable. It's very much per-display only.
Comment #5
dawehnerOkay now it works. Thanks for the solution!
Comment #6
dawehnerThe enabled/display_comment change should be backported. Just add this as a note.
Comment #7
dawehnerThis is fixed now.
A possible follow up would be to use ajax here.
The backport is also done.