Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.defined this.input but never get use ?? pure access to ID is more better.
(Version: should I point to D8 and port back ?)
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | core-js-autocomplete-id-1099062-5.patch | 480 bytes | nod_ |
| #5 | core-js-autocomplete-id-1099062-5-D7.patch | 460 bytes | nod_ |
| autocomplete.patch | 452 bytes | droplet | |
Comments
Comment #1
catchLooks sensible enough, we miss a js testing framework for patches like this.
Comment #2
nod_I don't really see the use of this, there is virtually no impact on performance. Optimize a selector somewhere and you get tens or hundreds of times the performance boost this gives you.
The input is used later in the code.
Drupal.jsACis a constructor, it's not just a function, the comment is misleading.Comment #3
nod_Turns out I was wrong : http://jsperf.com/el-attr-id-vs-el-id/2 It does matter. Might want to look elsewhere too.
Selector improvement is a bigger win though.
Comment #4
Dries CreditAttribution: Dries commentedThat is a pretty cool test. This patch doesn't seem to apply though.
Comment #5
nod_Comment #6
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedApplies now.
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x and 7.x. Thanks for the quick re-roll.
Comment #8
droplet CreditAttribution: droplet commentedThanks. It's waited 10 months.
created a follow up issue for other parts:
#1099062: autocomplete.js micro optimization