API page: http://api.drupal.org/api/drupal/modules--search--search.module/function....

The documentation for search_box() makes a reference to theme_search_box_form() in the "see also" section, but the function is not found in Drupal 6.

Files: 
CommentFileSizeAuthor
#11 search_box-1098556-11.patch481 bytesrocket_nova
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es). View
#2 theme_search_box_form-1098556.patch446 bytesbarbi
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es). View

Comments

jhodgdon’s picture

Title: The documentation for search_box() contains a reference to theme_search_box_form(), but the function doesn't exist in Drupal 6 » search_box() doc refers to nonexistent theme_search_box_form()
Issue tags: +Novice

Yeah, that @see should be removed. I can't see anything to replace it with either. Good project for a novice doc contributor.

barbi’s picture

Assigned: Unassigned » barbi
Status: Active » Needs review
FileSize
446 bytes
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es). View
mr.baileys’s picture

I think it's supposed to link to theme_search_block_form instead of theme_search_box_form.

If we change the function name in @see (rather than removing the reference) then we should also add a reference for theme_search_theme_form.

jhodgdon’s picture

Why is theme_search_block_form() relevant to this function? I don't think it's called from this function or very related? Besides which, theme_search_block_form() is not a real function. It's a dummy that shouldn't even exist on the API site, since it's just saying "this is really search-block-form.tpl.php.

Same with theme_search_theme_form() -- why relevant and isn't really a function.

mr.baileys’s picture

It's relevant for someone looking to theme the search box form. I'm ok with removing the references though, I was just curious where the current reference to theme_search_box_form came from.

jhodgdon’s picture

Status: Needs review » Needs work

Status was never changed.

This should just link to search-block-form.tpl.php as it does in Drupal 7/8. Good project for a novice patch contributor. Oh, it's already tagged. :)

jhodgdon’s picture

Assigned: barbi » Unassigned

un-assigning since barbi hasn't worked on this in quite a long time.

Everett Zufelt’s picture

jhodgdon’s picture

This is a 6.x-only issue, so I don't think the proposed removal of search-block-form.tpl.php in 8.x affects us here. But hopefully that issue's patch will also remove the link in the doc header for 8.x...

rocket_nova’s picture

Assigned: Unassigned » rocket_nova

Working on this at BADCamp.

rocket_nova’s picture

Status: Needs work » Needs review
FileSize
481 bytes
PASSED: [[SimpleTest]]: [MySQL] 190 pass(es). View

Removed reference to theme_search_box_form() and added reference to search-block-form.tpl.php.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed, pushed.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.