When adding a menu link and specifying "#" as path, two notices are generated and the validation message is incorrect:

  • Notice: Undefined index: path in menu_edit_item_validate() (line 380 of modules/menu/menu.admin.inc).
  • Notice: Undefined index: path in menu_edit_item_validate() (line 381 of modules/menu/menu.admin.inc).
  • The path '' is either invalid or you do not have access to it.

Patch attached to fix this, including a test for this edge case.

CommentFileSizeAuthor
#7 Screen Shot 2012-03-23 at 3.05.56 PM.png66.31 KBzeropx
#5 menu-notices-1096208-5.patch1.05 KBzambrey
menu-notices.patch1.04 KBmr.baileys

Comments

catch’s picture

catch
he/him
Primary language English
commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D7

Looks great.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x and 7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

grasmash’s picture

grasmash commented

Still experiencing this error in 7.10, which was released in Dec. Is this still in 7.x-dev ?

zambrey’s picture

zambrey commented
Version: 8.x-dev » 7.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new menu-notices-1096208-5.patch1.05 KB

Seems like this was never commited to 7.x branch.
Attaching rerolled patch.

zeropx’s picture

zeropx commented

@zambrey I have tested and can validate the patch worked.

zeropx’s picture

zeropx commented
StatusFileSize
new Screen Shot 2012-03-23 at 3.05.56 PM.png66.31 KB

Forgot to attach a screen shot, here you go.

Screen Shot 2012-03-23 at 3.05.56 PM.png

zambrey’s picture

zambrey commented

Yes, this is expected behavior. The notices are gone.

dcam’s picture

dcam commented

#5: menu-notices-1096208-5.patch queued for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I also tested #5. I got the same result as zeropx in #7. The patch fixes the issue by eliminating the PHP errors. Marking this as RTBC.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/79c6205

Status: Fixed » Closed (fixed)
Issue tags: -Needs backport to D7

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Needs backport to D7

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.