Can't override display's comments and "Group by" section . [#1091986]

Dear module maintainers,
Thank you for wonderful module and for continuous work on it.

When i edit display's comment field, i don't see an override button.
So, in this case when we write a comment, it is showing on all displays.
Instead, I expect that every display will have it's own independend comment field.

Thank you.

Comment	File	Size	Author
#6	1091986-display_comment-groupby-override.patch	906 bytes	dawehner
#6
#3	1091986-display_comment-groupby-override.patch	812 bytes	intyms
#3
#1	1091986-display_comment-override.patch	537 bytes	dawehner
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dawehner

German

CreditAttribution: dawehner commented 14 March 2011 at 22:38

Status:

Active

» Needs review

File	Size
1091986-display_comment-override.patch	537 bytes

Here is a patch to fix this.

Comment #2

intyms CreditAttribution: intyms commented 15 March 2011 at 08:59

Status:

Needs review

» Reviewed & tested by the community

Thank you, it's working great !

Comment #3

intyms CreditAttribution: intyms commented 15 March 2011 at 17:26

Title:	Can't override display's comments.	» Can't override display's comments and "Group by" section .
Status:	Reviewed & tested by the community	» Needs review

File	Size
1091986-display_comment-groupby-override.patch	812 bytes

"Group by" also doesn't have a possibility to be overriden.
Here is a patch which includes fixes for both "comments" and "group by" sections.

Comment #4

intyms CreditAttribution: intyms commented 18 March 2011 at 10:10

Status:

Needs review

» Reviewed & tested by the community

I tested "comments" and "group by" override feature. It's working well. Dereine thank you.

Comment #5

merlinofchaos CreditAttribution: merlinofchaos commented 22 March 2011 at 19:31

Status:

Reviewed & tested by the community

» Needs work

That's strange. Display comment should not be overridable; it should always be unique per display. It should neither be overridable *nor* defaultable.