There is a problem in Drupal.Views.parseQueryString function. We decode values of the the variables, but we don't decode the names of variables. This causes problems when there is GET parameter passed having encoded charachters.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1090270-base.js-parseQueryString-7.x-3.x-reroll.patch | 837 bytes | ygerasimov |
| #3 | 1090270-base.js-parseQueryString-6.x-3.x.patch | 843 bytes | ygerasimov |
| #3 | 1090270-base.js-parseQueryString-7.x-3.x.patch | 837 bytes | ygerasimov |
| #1 | 1090270-base.js-parseQueryString.patch | 837 bytes | ygerasimov |
Comments
Comment #1
ygerasimov commentedHere is patch to review.
Comment #2
dawehnerThis would have to be fixed on 6.x-3.x, too, so move the version.
Comment #3
ygerasimov commentedHere are patches for both 6.x-3.x and 7.x-3.x branches.
Comment #4
ygerasimov commented@dereine Is anything else expected from me to be done for this patch?
Comment #5
ygerasimov commentedHere is reroll of the patch to 7.x-3.x
Comment #6
merlinofchaos commentedCan you give me good instructions on reproducing the bug this fixes?
Comment #7
ygerasimov commentedThe bug is comes up when name of the variable that is sent has non alphanumeric symbols. In my case I needed to send variable with colon (needed in AJAXifying facets of the View based on Search API solr backend). Instructions how to build this view can be found in article http://ygerasimov.com/ajaxified-solr-search-drupal-search-api-views-panels
Comment #8
merlinofchaos commentedCommitted to 6.x and 7.x