I found a typo in the rebuild function name. Going to try rolling a patch to fix it & call to it (my second time around on patching evar!)

CommentFileSizeAuthor
#5 1089908-og_statistics-typo-5.patch459 bytesjeffschuler
#2 docs-fix-1089908-0.patch1.87 KBhongpong
#1 docs-fix-1089908-1.patch2.63 KBhongpong

Comments

hongpong’s picture

hongpong commented
Status: Active » Needs review
StatusFileSize
new docs-fix-1089908-1.patch2.63 KB

Alright they're kicking us out of code sprint now, but I think this covers what needs to be done. I forgot one ref... but yeah it looks like the 2nd patch has all of em. my 2nd & 3rd patches respectively. thnx for yr review

hongpong’s picture

hongpong commented
StatusFileSize
new docs-fix-1089908-0.patch1.87 KB

this was the first one. not needed i think. (it's missing the last fix).

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Thanks again!

Commited, added a changelog entry and added you to the commit message.

git commit --amend really rocks :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new 1089908-og_statistics-typo-5.patch459 bytes

Looks like the patch from #2 was committed instead of the complete solution in #1, because one of these typos still remains.

This patch fixes that one.

hefox’s picture

hefox commented
Status: Needs review » Reviewed & tested by the community

Works and fixes the issue

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Oh totally forgot about this patch, thanks for it!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.