Block module contains:

  // Populate all block regions
  $all_regions = system_region_list($theme);

The line "Populate all block regions" is misleading, because system_region_list() isn't populating block content.

It would be easier for developers to understand if this line read: "Fetch a list of regions for the current theme."

CommentFileSizeAuthor
#1 1089430.patch484 bytesmanarth

Comments

manarth’s picture

manarth commented
Status: Active » Needs review
StatusFileSize
new 1089430.patch484 bytes

Patch attached.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Needs review » Reviewed & tested by the community

Temporarily changing to 7.x so the test bot can fire. The patch seems fine to me and should be committed to 7.x and 8.x in my opinion.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 7.x-dev » 8.x-dev

moving back to 8.x so it can be committed properly to 7.x and 8.x

dries’s picture

dries commented
Version: 8.x-dev » 7.x-dev

Committed to my local 8.x tree. Will be pushed later today. Thanks. Moving to 7.x.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.