Location cck field formatters that use gmaps don't work properly

I know about this but have not had a chance to track down the problem yet.

It is a bug that affects all formatters that use gmaps in their display.

If you are getting "Javascript is required to view this map" instead of a map it is the same problem I have seen (Your screenshots don't seem to have attached correctly).

Subscribe

Hello!
Looks like it's the same issue with my installation.
And this can hardly be the mentioned javascript gmap issue
On my site only "Array" shows up instead of coordinate chooser on node editing form.
But on Gmap settings and macro creation pages all maps are displayed properly.

@natkitten:

Have you checked the "Use a Google Map to set latitude and longitude " option on the location settings page (admin/config/content/location/main)?

This issue is for when you are viewing a node, not editing a node.

The "Array" you see is another issue, see #1056148: 'Array' appears at the bottom of locations on node edit page.

Oh my... sorry for posting a stupid question to the wrong thread...
"Use a Google Map..." hasn't been checked...
Thanks so much! I just used the wrong administration page assuming everything necessary was in "gmap location" settings...
Node edit works fine now.
And the "javascript required" issue belongs completely to Gmap module, i guess.

I am also having problems displaying the actual map image. I get the same appearance as youssefr with only the coords appearing and no google map.

I'm also having this issue. I have tried everything above - made sure the block was active as well - no change.
I just get the label and no map.

Ended up using this:
https://github.com/mindtree/BingMapsDrupal

Unfortunately, the bing map broke javascript on the page.

This issue exists in the latest 6.x version also.

subbing

I have the fix for this, coming asap.
Will have time to give some location love again very soon.

subscribing!

Try this.
Should work for all 3 formatters that use the map.

That is not the complete code of the theme_location_cck_field_map() function, it is just the portion of it that was patched, so it won't work by itself. It has to be the current code in that function combined with the changes in the patch file.

You don't have to add anything to your template.php file.
Just apply the patch in #19 to the location module and the problem should be fixed.
Then if people can report here whether or not the patch fixes the problem (does for my testing) it can be committed to the module.

There is loads of patch related informatino at http://drupal.org/patch and its related pages.
for this patch you should be able to just copy the patch file into the location module folder (the main folder, not the location_cck one) and run the following command (from within the location directory):
patch -p1 < location-cck_map_formatters-1089344-19.patch

Looks like you are doing the right thing,
When I run it I get:

patching file contrib/location_cck/location_cck.module
Hunk #1 succeeded at 477 (offset 2 lines).

Are you using the latest location 7.x-3.x-dev?

When you are finished the function should look like:

<?php
/**
 * Generate a GMap map for one or more location field values.
 *
 * Mostly just cut and paste from gmap_location
 * block view.
 */
function theme_location_cck_field_map($variables) {
  $locations = $variables['locations'];
  $field = $variables['field'];
  $instance = $variables['instance'];

  $count = 0;
  $content = '';
  foreach ($locations as $location) {
    if (location_has_coordinates($location)) {
      $count++;
      $markername = isset($field['settings']['gmap_marker']) ? $field['settings']['gmap_marker'] : 'drupal';
      $markers[] = array(
        'latitude' => $location['latitude'],
        'longitude' => $location['longitude'],
        'markername' => $markername,
        'offset' => $count-1,
        'text' => theme('location_cck_field_popup', array('location' => $location, 'instance' => $instance)),
      );
    }
  }
  if (!empty($markers)) {
    $macro = !empty($field['settings']['gmap_macro']) ? $field['settings']['gmap_macro'] : '[gmap ]';
    $map = array_merge(gmap_defaults(), gmap_parse_macro($macro));
    $map['latitude'] = $markers[0]['latitude'];
    $map['longitude'] = $markers[0]['longitude'];
    $map['markers'] = $markers;
    $map['id'] = gmap_get_auto_mapid();
    // Render a map element.
    $location_map = array(
      '#type' => 'gmap',
      '#gmap_settings' => $map,
    );
    $content = drupal_render($location_map);
  }

  return $content;
}
?>

You could even try just replacing the function with the code here but if you are not using the latest 7.x-3.x it may cause problems to do that depending on what your version is.

Ah, that's why then. This issue is for drupal 7 so the patch is for drupal 7 too.
When I get home tonight I'll make one for drupal 6 and post it here.

The fix should be similar but the code in this one definitely won't work with drupal 6 even if you manually copy the code I posted above.

rooby, thank you! your patch solved my problems and now the map is printed in my nodes!
i just had manually opened location_cck.module in editor and paste your changes.

For all those who say they have this problem in drupal 6 can you give some more details of what your problem is.
I cannot reproduce this on drupal 6 running location 6.x-3.x-dev.

If the problem is that the "Multiple field values on a single map" display formatter is not working you want this issue #841340: Location CCK and Multiple field values on a single map

Sorry, since this issue was originally posted for the drupal 7 version I thought it was the problem which is for all cck formatters that use gmaps in the drupal 7 version you only see this text:
"Javascript is required to view this map"

This is not the same problem as the issue you are seeing.
If you locations don't have latitude and longitude values a map will not display.
In your second screenshot this may be the case but in your original one there are coordinates so that is probably not it.

Off the top of my head I can't think of other reasons why this would happen.
I'll have to have a think.

I guess if you are comfortable editing code in your location_cck.module file, then in the function

function theme_location_cck_formatter_all($element) {

In between the lines (at the bottom of the function:

  $content .= theme_location_cck_field_map(array($location), $field);
  return $content;

Add the following lines:

var_dump('element');
var_dump($element);
var_dump('location');
var_dump($location);
var_dump('field');
var_dump($field);

Then go to your browser and view one of the problem nodes.
You should get a big message displaying a lot of text. If you don't try a refresh.
If you still don't let me know.
If you do get the text (you should), can you paste the text into a text file and attach here.

Then you can remove those lines you added to the code again.

Setting back to D7 as that was what the original post was for and patch is for.
I'll still try to sort out your problem though and if it turns out to be a bug we can open a new issue for the different problem.

If you like I can have a look. I would need the required permissions for administering content types, creating or administering nodes, administering location & gmap although I can't promise being able to solve it as sometimes filesystem access and debugging is required.

For reference, the problem youssefr was seeing was not a bug and has been resolved.

Committed the patch in #19.
http://drupalcode.org/project/location.git/commit/8e30e68

I'm having this problem and what is odd is that it was working for location CCK - and now it is not. A map will display for a node location in a block but that's not really what I need. Anyone else? Any suggestions?