Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
Thanks for getting on this Dave! Unless there's already an issue for it, I'll start working on removing all the 7xxx updates so we can add in the 8000 ones (when they exist).
It's applying cleanly and working. But "avaibale updates" page tells me:
Drupal core 8.0-dev Unknown release date
Recommended version: 8.x-dev (2011-Mar-10)
You might wish to change 8.0-dev to 8.x-dev? :) I'm not 100% sure but I think 8.0 is the number of a final release, it should be 8.x.
But hey, patch is looking good so far. :)
Edit: changed it to 8.x-dev manually and it's still complaining "Unknown release date". Not sure why. (I need to mention I have a live website running the "8.x-dev" release as of Mar-10, 2011 and that's not complaining :)
- // During a Drupal 6.x to 7.x update, drupal_get_schema() does not contain
+ // During a Drupal 6.x to 8.x update, drupal_get_schema() does not contain
// the queue table yet, so we cannot rely on drupal_write_record().
$query = db_insert('queue')
->fields(array(
The 7000 here probably need to be bumped to 8000 too.
DamZ: Could you look at #1097100: Remove all 7xxx update functions and tests (D6 to D7 upgrade path)? This fixes most of the issues you raise and deals with the update functions and the "drupal-6.*.database.php" files by removing them (since we don't need to test upgrading from D6 to D8 anyway). It might be a bit aggressive, but right now there's nothing to test when it comes to upgrading from D7 to D8.
Comments
Comment #1
dave reidSummary:
- Changes all the 'core = 7.x' lines in .info files to 8.x
- Updates core compatability constants
- Fixes CHANGELOG.txt, MAINTAINERS.txt (to remove Angie - sadness), and UPDATE.txt
Comment #2
quicksketchThanks for getting on this Dave! Unless there's already an issue for it, I'll start working on removing all the 7xxx updates so we can add in the 8000 ones (when they exist).
Comment #3
quicksketchFollow up to this issue: #1097100: Remove all 7xxx update functions and tests (D6 to D7 upgrade path).
Comment #4
wizonesolutionsTested applying this - applies cleanly, all changes look to be there. +1.
Also, this is my first core patch review! Start at the beginning, right? :D
Comment #5
donSchoe commentedIt's applying cleanly and working. But "avaibale updates" page tells me:
You might wish to change 8.0-dev to 8.x-dev?:)I'm not 100% sure but I think 8.0 is the number of a final release, it should be 8.x.But hey, patch is looking good so far. :)
Edit: changed it to 8.x-dev manually and it's still complaining "Unknown release date". Not sure why. (I need to mention I have a live website running the "8.x-dev" release as of Mar-10, 2011 and that's not complaining :)
Comment #6
dries commentedNice one. Committed to CVS HEAD.
Comment #7
damien tournoud commentedThe 7000 here probably need to be bumped to 8000 too.
Please revert this change.
7.x to 8.x?
Comment #8
quicksketchDamZ: Could you look at #1097100: Remove all 7xxx update functions and tests (D6 to D7 upgrade path)? This fixes most of the issues you raise and deals with the update functions and the "drupal-6.*.database.php" files by removing them (since we don't need to test upgrading from D6 to D8 anyway). It might be a bit aggressive, but right now there's nothing to test when it comes to upgrading from D7 to D8.
Comment #9
donSchoe commentedSee #8.