Here are some coding standards errors caught by Coder module

CommentFileSizeAuthor
#3 108717.patch1.37 KBneclimdul
#1 contact-cleanup_0.patch1.37 KBadd1sun
contact-cleanup.patch1.08 KBadd1sun

Comments

add1sun’s picture

add1sun commented
StatusFileSize
new contact-cleanup_0.patch1.37 KB

Corrected patch.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work

I think the parentheses around those return values are not helping anything; they should be removed.

neclimdul’s picture

neclimdul
He/Him
commented
Assigned: Unassigned » neclimdul
Status: Needs work » Needs review
StatusFileSize
new 108717.patch1.37 KB

Yuck! Luckily fixed in 6 and beyond but we can fix this still...

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Committed to 5.x.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.