Comments of the function drupal_map_assoc() have a @result, that seems to be a invalid Doxygen directive. I think that would be an @return instead.

CommentFileSizeAuthor
#11 docs_1087092.patch415 bytesdrewish
#8 1087092-6.x.patch407 bytesdanillonunes
#1 0001-1087092-Fix-documentation-for-drupal_map_assoc-function.patch753 bytesdanillonunes

Comments

danillonunes’s picture

danillonunes commented
StatusFileSize
new 0001-1087092-Fix-documentation-for-drupal_map_assoc-function.patch753 bytes

I made a patch against 7.x branch, using git-format-patch. Would be nice if it's applied with git-am, so the commit will be assigned to me and I can track easily all my little contributions to Drupal.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Active » Needs review

When adding a patch, please set the status to "needs review" so both human and testbot reviewers can review the patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Anyway, thanks for finding this problem, filing the issue, and making the correct patch!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x! Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

By the way, thanks to Bdragon, dww, marvil07, eliza411, and at least 4 other people for making this commit/push possible. ;)

danillonunes’s picture

danillonunes commented

Thanks!

I see that you made a new commit instead of using the one I had done, is there some specific reason for that? Or it's a not discussed question yet? It's fine for me, but just to know because if is the case I can made future patches in the old way that will be cleaner and easier to review/commit. :-)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Yeah, basically I did that for consistency. I'd looked at Dries's commit since the Git migration and he stuck with the "old" style patch committing that we used to do with CVS. I figured that was best, at least for 7.x, since that's how all of our old patches went in.

For 8.x, however, git am probably makes a lot more sense since there's a clean break in history.

danillonunes’s picture

danillonunes commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Needs review
StatusFileSize
new 1087092-6.x.patch407 bytes

Ok. Oh, and congratulations for your first commit/push to drupal.git! :-)

Also, this issue exists on 6.x too.

drewish’s picture

drewish commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1087092-6.x.patch, failed testing.

drewish’s picture

drewish commented
Status: Needs work » Needs review
StatusFileSize
new docs_1087092.patch415 bytes

re-rolling.

Status: Needs review » Needs work

The last submitted patch, docs_1087092.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

#961172: All D6 Core patches are failing - ignore test failures... patch looks fine to me.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

#11: docs_1087092.patch queued for re-testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed, pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.