DrupalEntityControllerInterface::load - doc needs to clarify $conditions

What problem did you find that you want to point out here?

Yes, equality. We should probably make that clearer in the doc. Good project for a novice doc patch contributor...

This issue here is already a request to update the documentation. We don't really need two. I've closed the other issue as a duplicate.

From that other issue -- suggested change is:

$conditions An array of conditions in the form 'field' => $value where each 'field' is tested for equality against the corrisponding $value.

Aside from the spelling of corresponding, and I'm not sure about 'field' vs. $value, something like this makes sense. Still needs a patch...

By the way, it's definitely possible to make patches on Windows. I did it for several years, though I'm not using Windows at this time.... There are instructions in http://drupal.org/documentation/git and subpages

We should also update DrupalEntityControllerInterface::buildQuery since it has basically the same documentation.

What do people think about this? I felt it was important to make it clear that the conditions must be on the base table and are ANDed together.

   * @param $conditions
   *   An array of conditions. Keys are field names on the entity's base table.
   *   Values will be compared for equality. All the comparisons will be ANDed
   *   together.

That looks reasonable to me. Just needs a patch...

>Values will be compared for equality.

That's not entirely true. If you pass an array as value, DB-TNG and so entity-load will default to use the operator IN for comparison.

In that regard I think core also suffers the problem I noted in #1008324-5: problem applying conditions with an array as value, thus cacheGet() would fail to apply the same condition. entity_load() would continue with loading the entity from the DB then, though.

>Values will be compared for equality.

That's not entirely true. If you pass an array as value, DB-TNG and so entity-load will default to use the operator IN for comparison.

Debatable. As far as I know, it was never the intent of the Entity API to support array conditions. The fact that it works by chance when the hitting the DB query directly does not mean it is supported.

Also, we need to add there that $conditions is deprecated in favor of EntityFieldQuery.

If folks can agree on the update I can roll the patch :)

>The fact that it works by chance when the hitting the DB query directly does not mean it is supported.

Indeed, but one really cannot know as it's un-documented. I think, fixing it to work like #9 makes sense as it makes things clear - but this might break some existing code...

In D8, it looks like DrupalEntityControllerInterface::load has moved to EntityStorageControllerInterface::load, while DrupalEntityControllerInterface::buildQuery has moved to DatabaseStorageController::buildQuery.

Setting to active until we get a patch as per http://drupal.org/node/156119.

#1184272: Remove deprecated $conditions support from entity controller removes conditions, but probably needs better docs as well.

Moving this to D7 since in D8 we have removed conditions, the load function is now located in https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21... and https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

Submitting a patch taking into consideration comments 9 and 7.Now a further discussion can take place so as to decide what needs to be updated in this patch.
Thanks.

I am not sure why the current patch has two different versions of the documentation for those two different classes? Let's make them the same. Then we need to address #12 and suggest people use an entity query instead of these methods anyway.

Submitting the patch along with a interdiff file.Please review.
Thanks.

Almost there!

The only problem I can see now is that EntityFieldQuery is a class, not a function. So I think I would say "... deprecated; use an EntityFieldQuery instead."; maybe you can come up with better wording? In any case, it shouldn't have () after it.

Submitting a patch with an interdiff file.Please review.
Thanks.

This looks reasonable to me. Provisionally setting to RTBC pending any further reviews. Thanks!

testboot hickup setting rtbc per #24

Thanks again! Committed to 7.x.