http://drupal.org/node/1011698
Description: A detailed description of what your project does, including how it is different from other, similar projects, if applicable.
Can you also include details on how this module differs from any that are similar?
At the first look, the module is almost identical (I checked first 150 lines) to imagemagick, just changed keywords. Wouldn't it be cool if ImageMagick module could be extended to support both libraries? I would personally say that's the way forward...
Yes, code for this module is copy from imagemagick (and it is described on module main page). I offered several times to add a gm call to imagemagick module, but author does not change his code for gm support. So, I propose the copy of imagemagick, but worked with graphicmagick.
Thank you.
@W32: Sorry, but that's not true. It's the exact opposite. I've actively asked you for a patch against ImageMagick module to add GraphicsMagick support. Publicly documented in #1066646-3: GraphicsMagick support. It was you who objected the offer right afterwards.
Because I couldn't believe that support for the GraphicsMagick fork would require larger changes, I took the time to review the changes in the GraphicsMagick sandbox, only to find out that zero changes are needed.
Comments
Comment #1
avpadernoComment #2
meba commentedhttp://drupal.org/node/1011698
Description: A detailed description of what your project does, including how it is different from other, similar projects, if applicable.
Can you also include details on how this module differs from any that are similar?
Comment #3
meba commentedAt the first look, the module is almost identical (I checked first 150 lines) to imagemagick, just changed keywords. Wouldn't it be cool if ImageMagick module could be extended to support both libraries? I would personally say that's the way forward...
Comment #4
gregglesMarking won't fix as it's been over 2 weeks since the request for information without any response.
@W32, when you respond please change the status back to needs review.
Comment #5
sun-1
http://drupal.org/sandbox/W32/1077458 is a 99.99% copy of http://drupal.org/project/imagemagick, the only changes are:
Obviously also missing all bug fixes and improvements that went into imagemagick module since the time it was "forked" (copied).
Comment #6
W32 commentedYes, code for this module is copy from imagemagick (and it is described on module main page). I offered several times to add a gm call to imagemagick module, but author does not change his code for gm support. So, I propose the copy of imagemagick, but worked with graphicmagick.
Thank you.
Comment #7
sun@W32: Sorry, but that's not true. It's the exact opposite. I've actively asked you for a patch against ImageMagick module to add GraphicsMagick support. Publicly documented in #1066646-3: GraphicsMagick support. It was you who objected the offer right afterwards.
Because I couldn't believe that support for the GraphicsMagick fork would require larger changes, I took the time to review the changes in the GraphicsMagick sandbox, only to find out that zero changes are needed.